Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

How can I find out why Renovate closes the Pull Request? #632

Closed
emmenko opened this issue May 4, 2020 · 13 comments
Closed

How can I find out why Renovate closes the Pull Request? #632

emmenko opened this issue May 4, 2020 · 13 comments

Comments

@emmenko
Copy link

emmenko commented May 4, 2020

Which Renovate are you using?

WhiteSource Renovate App

Which platform are you using?

GitHub.com

Have you checked the logs? Don't forget to include them if relevant

I tried but it keeps showing me the "Please authenticate" page. πŸ€·β€β™‚οΈ

image

What would you like to do?

Recently I noticed that the (scheduled) Pull Request opened by Renovate suddenly gets closed, and I can't figure out the reason why is that. Even if I manually reopen it, it then gets closed again.

For example:

image

Any help would be appreciated, thanks.

@stale stale bot added the pending-closure label May 7, 2020
@emmenko
Copy link
Author

emmenko commented May 7, 2020

Ping

@stale stale bot removed the pending-closure label May 7, 2020
@renovatebot renovatebot deleted a comment from stale bot May 7, 2020
@rarkins
Copy link
Collaborator

rarkins commented May 7, 2020

Renovate generally doesn't "know" why a PR needs closing - it just knows which PRs should exist, and closes any that shouldn't (unless you disable that feature and clean up PRs yourself).

Sometimes it can occur because a datasource was unavailable temporarily, and was not treated as an essential "datasource failure" to abort the run. In such cases you should expect to see a new PR opened once the datasource responds the next time.

If you compare the debug logs between runs then the differences may give you a hint as to why it wasn't kept open. If the dashboard still isn't working for you then please raise that as a separate issue in https://github.com/renovatebot/app-support

@emmenko
Copy link
Author

emmenko commented May 7, 2020

Thanks for the feedback. The weird thing is that recently it seems to happen "consistently" across some of our repositories.
Also from the screenshot above you can see that when the ZEIT Now (Vercel) deployments failed, the PR got closed by the Renovate bot. Was it just a coincidence?

If the dashboard still isn't working

Tried again, it's working now πŸ‘Œ

@rarkins
Copy link
Collaborator

rarkins commented May 7, 2020

Was it just a coincidence?

I would think it's just a coincidence, but things like this have surprised me before. I recommend:

  • Look at the exact time stamp for when it was autoclosed
  • Match that timestamp against the logs in the dashboard to find the right job
  • Look at that job's logs for that branch
  • If still unclear, download and compare the job's logs with the job before it, as hopefully that might give a hint

@emmenko
Copy link
Author

emmenko commented May 7, 2020

Alright, thanks a lot for the feedback. I'll try to find out more in the logs when I have some time.

@emmenko emmenko closed this as completed May 7, 2020
@emmenko
Copy link
Author

emmenko commented May 11, 2020

@rarkins Hi, so I've been trying to look at the logs, as Mondays we have the scheduled update and the issue this occurs.

I'm starting to wonder if the problem is somehow related to having a scheduled update time. In the logs I see this:

image

Does not match schedule because 63391 is later than 18000

I can't find any other useful logs that might explain the behavior.

I could try removing the schedule and observe if the issue still occurs. Do you think it would help?

PS: my renovate config is like this

{
  "extends": [
    "config:base",
    ":pinOnlyDevDependencies",
    "schedule:weekly"
  ],
  "separateMajorMinor": true,
  "groupName": "all dependencies",
  "groupSlug": "all",
  "packageRules": [
    {
      "packagePatterns": [
        "*"
      ],
      "groupName": "all dependencies",
      "groupSlug": "all"
    }
  ],
  "lockFileMaintenance": {
    "enabled": true
  },
  "labels": ["πŸ€– Type: Dependencies"],
  "ignoreDeps": []
}

@emmenko emmenko reopened this May 11, 2020
@rarkins
Copy link
Collaborator

rarkins commented May 11, 2020

That log doesn't show any Pull Request being closed, does it? I can't search it easily because it's a screenshot

@emmenko
Copy link
Author

emmenko commented May 11, 2020

Example PR: commercetools/commercetools-docs-kit#432

Logs: https://app.renovatebot.com/dashboard#github/commercetools/commercetools-docs-kit/175489642

This one maybe? (I admit I'm a bit confused to what I should look for)

image

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2020

Seems that something is going wrong with the mix of lockFileMaintenance. Here's what I suggest for your config:

{
  "extends": [
    "config:base",
    ":pinOnlyDevDependencies",
    "schedule:weekly"
  ],
  "separateMajorMinor": true,
  "packageRules": [
    {
      "packagePatterns": [
        "*"
      ],
      "updateTypes": ["minor", "patch"],
      "groupName": "all dependencies",
      "groupSlug": "all"
    }
  ],
  "lockFileMaintenance": {
    "enabled": true
  },
  "labels": ["πŸ€– Type: Dependencies"],
  "ignoreDeps": []
}

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2020

BTW I am also removing the rule that seems to be misfiring for you. But I recommend you don't combine major updates into that all updates.

@emmenko
Copy link
Author

emmenko commented May 11, 2020

Great, thanks a lot for looking into it and for the suggestion! πŸ™

I’ll let you know how that goes

@stale
Copy link

stale bot commented May 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs.

@emmenko
Copy link
Author

emmenko commented May 18, 2020

Things look good now with the updated config. Thanks again for the help! πŸ™

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants