From 751331b817a5db1d71f13610e4e874a6a7295c47 Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Fri, 16 Dec 2022 10:17:16 +0100 Subject: [PATCH 1/2] fix: no native js private class members (#19441) --- lib/config/migrations/migrations-service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/config/migrations/migrations-service.ts b/lib/config/migrations/migrations-service.ts index 0ded6715208a15..6f7dbf03b41f48 100644 --- a/lib/config/migrations/migrations-service.ts +++ b/lib/config/migrations/migrations-service.ts @@ -144,7 +144,7 @@ export class MigrationsService { for (const [key, value] of Object.entries(originalConfig)) { migratedConfig[key] ??= value; - const migration = MigrationsService.#getMigration(migrations, key); + const migration = MigrationsService.getMigration(migrations, key); if (migration) { migration.run(value, key); @@ -202,7 +202,7 @@ export class MigrationsService { return migrations; } - static #getMigration( + private static getMigration( migrations: ReadonlyArray, key: string ): Migration | undefined { From 33bf3730dd2f9b4c3befbec92c45517dd5312df7 Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Fri, 16 Dec 2022 10:35:51 +0100 Subject: [PATCH 2/2] chore: reverse template orders --- .github/ISSUE_TEMPLATE/bug_report.yml | 4 ++-- .github/ISSUE_TEMPLATE/feature_request.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 2f55fb0b2ab7a3..8463bb456ee498 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -106,8 +106,8 @@ body: label: Have you created a minimal reproduction repository? description: Please read the [minimal reproductions documentation](https://github.com/renovatebot/renovate/blob/main/docs/development/minimal-reproductions.md) to learn how to make a good minimal reproduction repository. options: - - 'I have linked to a minimal reproduction repository in the bug description' - - 'No reproduction, but I have linked to a public repo where it occurs' - 'No reproduction repository' + - 'No reproduction, but I have linked to a public repo where it occurs' + - 'I have linked to a minimal reproduction repository in the bug description' validations: required: true diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index d35f82640591f8..e902133f6b5d27 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -25,8 +25,8 @@ body: attributes: label: Is this a feature you are interested in implementing yourself? options: - - 'Yes' - - 'Maybe' - 'No' + - 'Maybe' + - 'Yes' validations: required: true