Navigation Menu

Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Rancher apps #10246

Closed
michalformanek opened this issue May 31, 2021 · 4 comments
Closed

Terraform Rancher apps #10246

michalformanek opened this issue May 31, 2021 · 4 comments
Labels
manager:terraform Terraform package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@michalformanek
Copy link

michalformanek commented May 31, 2021

What would you like Renovate to be able to do?

We are using Terraform to manage Rancher apps and catalogs. These are esentially equivalent to Helm resources, which can be automatically updated by Renovate. Would it be possible to implement the same functionality for Rancher apps and catalogs?

https://registry.terraform.io/providers/rancher/rancher2/latest/docs/resources/app_v2
https://registry.terraform.io/providers/rancher/rancher2/latest/docs/resources/catalog_v2

Examples of these two resources used together:
https://registry.terraform.io/providers/rancher/rancher2/latest/docs/guides/apps_marketplace#examples-1

Did you already have any implementation ideas?
It might be easy to add new branch to switch here - https://github.com/renovatebot/renovate/blob/main/lib/manager/terraform/resources.ts#L98 We can even extract function from there, only difference is is obtaining registry url, which in case of catalogs is in another resource

@michalformanek michalformanek added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels May 31, 2021
@secustor
Copy link
Collaborator

secustor commented Jun 1, 2021

Definitely possible especially as we have already helm and git datasources, but we do not resolve references between resources at the moment. Because of that, the implementation will not be as simple as adding an additional case.

For reference what is needed for the implementation:

  • rather use extractAllPackageFiles than extractPackageFile
  • extract all relevant objects
  • resolve references between.

This could be later on integrated with variable resolution if combined with something akin to getSiblingFilesWithExtension(filename, fileExtension) to extract variables from separate files.

@rarkins rarkins added the auto:reproduction A minimal reproduction is necessary to proceed label Jun 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@rarkins
Copy link
Collaborator

rarkins commented Jun 1, 2021

As a first step let's get a minimal reproduction repo showing such a use case (particularly references between).

@rarkins rarkins added the manager:terraform Terraform package manager label Jun 1, 2021
@HonkingGoose HonkingGoose added status:waiting-on-response and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 18, 2021
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-5-triage labels Nov 25, 2022
@nerok
Copy link

nerok commented Dec 30, 2022

Hi,
I have the same need, here is a minimal reproduction based on my needs: https://github.com/nerok/Minimal-reproduction-for-renovate-to-work-with-rancher-provider-in-terraform

@viceice viceice added reproduction:provided and removed auto:reproduction A minimal reproduction is necessary to proceed labels Dec 30, 2022
@renovatebot renovatebot locked and limited conversation to collaborators Oct 1, 2023
@rarkins rarkins converted this issue into discussion #24929 Oct 1, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
manager:terraform Terraform package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

6 participants