Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: give write permissions to release phase only #16394

Merged
merged 1 commit into from Jul 2, 2022

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Jul 2, 2022

Changes

Give write permissions only to release job in build workflow

Context

Improves on:

test and lint phases are run on all pull requests. Giving the GITHUB_TOKEN write permissions for pull requests is slightly riskier than giving read-only permissions.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee JamieMagee changed the title ci/build-token-permissions ci: give write permissions to release phase only Jul 2, 2022
@JamieMagee JamieMagee enabled auto-merge (squash) July 2, 2022 18:32
@JamieMagee JamieMagee merged commit 108833a into main Jul 2, 2022
@JamieMagee JamieMagee deleted the ci/build-token-permissions branch July 2, 2022 18:35
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.103.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants