Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimumReleaseAge instead of stabilityDays #16875

Closed
Tracked by #19289
JavierSegoviaCordoba opened this issue Jul 31, 2022 · 5 comments · Fixed by #21376
Closed
Tracked by #19289

minimumReleaseAge instead of stabilityDays #16875

JavierSegoviaCordoba opened this issue Jul 31, 2022 · 5 comments · Fixed by #21376
Assignees
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@JavierSegoviaCordoba
Copy link
Contributor

JavierSegoviaCordoba commented Jul 31, 2022

What would you like Renovate to be able to do?

Get a flexible way to delay looking for new updates as commented here: #12133 (comment)

Related issue: #12310

If you have any ideas on how this should be implemented, please tell us here.

The summary mentioned by @rarkins is:

  • Rename it to be a bit more generic (e.g. "releaseDelay", but better)
  • We retire/migrate stabilityDays
  • Define a simple format for duration - or find one which already exists - so that it can be e.g. 1d2h3m. We might find use for such a format elsewhere

Is this a feature you are interested in implementing yourself?

No

@JavierSegoviaCordoba JavierSegoviaCordoba added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Jul 31, 2022
@HonkingGoose
Copy link
Collaborator

We also discussed some new names for the stabilityDays config option in this issue:

@rarkins
Copy link
Collaborator

rarkins commented Aug 1, 2022

The name minimumReleaseAge from #12914 is maybe more intuitive

@PhilipAbed PhilipAbed added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-5-triage labels Aug 9, 2022
@rarkins rarkins changed the title releaseDelay instead of stabilityDays minimumReleaseAge instead of stabilityDays Oct 17, 2022
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-4-low Low priority, unlikely to be done unless it becomes important to more people labels Oct 17, 2022
@rarkins
Copy link
Collaborator

rarkins commented Oct 17, 2022

The pretty-ms package converts from milliseconds to human readable string. I think we need to write the opposite, i.e. to convert from human-readable string back to a millisecond duration.

https://www.npmjs.com/package/pretty-ms

@rarkins
Copy link
Collaborator

rarkins commented Apr 6, 2023

@rarkins rarkins added status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 6, 2023
@rarkins
Copy link
Collaborator

rarkins commented Apr 6, 2023

Let's do it in a major release when we rename renovate/stability-days to renovate/minimum-release-age.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants