Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub App - PR Status Update - Validation Failed (422) #1779

Closed
2 of 7 tasks
ghost opened this issue Apr 3, 2018 · 2 comments
Closed
2 of 7 tasks

GitHub App - PR Status Update - Validation Failed (422) #1779

ghost opened this issue Apr 3, 2018 · 2 comments
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@ghost
Copy link

ghost commented Apr 3, 2018

This is a:

  • Bug report (non-security related)
  • Feature request
  • I'm not sure which of those it is

I'm using:

  • The Renovate GitHub App
  • Self-hosted GitHub
  • Self-hosted GitLab
  • Self-hosted VSTS

Please describe the issue:

There is a branch on a repository with the name refactor/renovate, and that branch has been opened as a Pull Request against the master branch. The branch contains a modification to the repository's renovate.json file.

In our Renovate App logs (for an on-premise Renovate) we are seeing the following:

 INFO: Setting PR validation status (repository=org/repo)
       "status": "success",
       "description": "Renovate config is valid"
DEBUG: GET repos/org/repo/git/refs/heads/refactor/renovate [retries=5] (repository=org/repo)
DEBUG: POST repos/org/repo/statuses/a434add208049301ef8334cb1299036deadb3016 [retries=5] (repository=org/repo)
 WARN: Error checking PR (repository=org/repo)

Contained in the error object is the following:

 "message": "Validation Failed (422)",
       "body": {
         "message": "Validation Failed",
         "errors": [
           {
             "resource": "Status",
             "code": "custom",
             "message": "This SHA and context has reached the maximum number of statuses."
           }
         ]
       },
       "prNo": 60,
       "branchName": "refactor/renovate"

On the following line I was able to see the following property values:

pr.branch - refactor/renovate
context - renovate/validate
description - Renovate config is valid
status - success

It looks like Renovate has been trying to set the status on every run, and it has exceeded the 1000 status updates that are allowed. (This is a rather old pull request, and our Renovate runs every 10 minutes)

@rarkins rarkins added type:bug Bug fix of existing functionality ready priority-2-high Bugs impacting wide number of users or very important features labels Apr 3, 2018
@rarkins rarkins self-assigned this Apr 3, 2018
@rarkins
Copy link
Collaborator

rarkins commented Apr 3, 2018

oh wow, I assumed if you use the same context for status set then it counts as one "status update".

@rarkins rarkins closed this as completed in ba98e7d Apr 3, 2018
@rarkins rarkins removed the ready label Apr 3, 2018
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.47.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants