Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify fns to adapt to new safe-stable-stringify package update #18573

Merged
merged 17 commits into from Nov 20, 2022
Merged

fix: modify fns to adapt to new safe-stable-stringify package update #18573

merged 17 commits into from Nov 20, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Oct 26, 2022 •
edited by rarkins

Changes

  • clone now returns null when the quickStringify function returns undefined
  • fingerprint now returns empty string when the safeStringify function returns undefined

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice requested changes Oct 26, 2022
View reviewed changes
lib/util/clone.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits October 26, 2022 15:13
@RahulGautamSingh @viceice
Update lib/util/clone.ts
c3a00b0 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh
Merge branch 'main' into fix/safe-stringify
62d83e3
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review October 26, 2022 10:02
viceice
viceice previously approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need new tests?

viceice
viceice reviewed Nov 7, 2022
View reviewed changes
lib/util/clone.ts Outdated Show resolved Hide resolved
lib/util/fingerprint.spec.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @viceice
Update lib/util/fingerprint.spec.ts
ce8d534 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
rarkins requested changes Nov 10, 2022
View reviewed changes
lib/util/clone.ts Outdated Show resolved Hide resolved
@rarkins rarkins merged commit c45c875 into renovatebot:main Nov 20, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RahulGautamSingh @renovate-release @viceice @rarkins @renovate-bot