Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to use temurin as a Java distribution name instead of adoptopenjdk in asdf .tool-version #19184

Closed
kota65535 opened this issue Nov 30, 2022 · 1 comment
Labels
manager:asdf Related to the asdf manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@kota65535
Copy link

kota65535 commented Nov 30, 2022

What would you like Renovate to be able to do?

Now AdoptOpenJDK is moved to Eclipse Adoptium project and also renamed to Temurin.
Since asdf-java plugin already handles these Temurin versions like temurin-17.0.5+8, so Renovate should accept temurin as well as adoptopenjdk as a distribution name.

If you have any ideas on how this should be implemented, please tell us here.

Maybe add a pattern to this regex below
https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/asdf/upgradeable-tooling.ts#L192

Is this a feature you are interested in implementing yourself?

Maybe

@kota65535 kota65535 added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Nov 30, 2022
@rarkins rarkins added manager:asdf Related to the asdf manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Nov 30, 2022
@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Nov 30, 2022

Are we sure we only need to change the regex linked above? Maybe we should change more things like:

  1. Do we want to add a new replacement preset to replace adoptopenjdk with temurin, file location: https://github.com/renovatebot/renovate/blob/main/lib/config/presets/internal/replacements.ts
  2. Our code and documentation still uses terms like:
    • AdoptOpenJDK
    • adoptium-java
    • AdoptiumJavaResponse
      Basically: search for adopt and see what pops up. 😉 Do we want to change those terms?
  3. We should maybe update the code for javaLTSVersions as that refers to adoptopenjdk:
    javaLTSVersions: {
    description: 'Limit Java runtime versions to LTS releases',
    packageRules: [
    {
    description:
    'Limit Java runtime versions to LTS releases. To receive all major releases add `workarounds:javaLTSVersions` to the `ignorePresets` array.',
    matchDatasources: ['docker', 'adoptium-java'],
    matchPackageNames: [
    'eclipse-temurin',
    'amazoncorretto',
    'adoptopenjdk',
    'openjdk',
    'java',
    'java-jre',
    'sapmachine',
    ],
    versioning:
    'regex:^(?<major>\\d+)?(\\.(?<minor>\\d+))?(\\.(?<patch>\\d+))?([\\._+](?<build>\\d+))?(-(?<compatibility>.*))?$',
    allowedVersions: '/^(?:8|11|17|21|25|29)(?:\\.|$)/',
    },
    ],
    },
  4. Maybe rename adoptium-java/AdoptiumJavaDatasource datasource?`

@HonkingGoose HonkingGoose added status:requirements Full requirements are not yet known, so implementation should not be started and removed status:ready labels Dec 5, 2022
@renovatebot renovatebot locked and limited conversation to collaborators Oct 1, 2023
@rarkins rarkins converted this issue into discussion #24927 Oct 1, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
manager:asdf Related to the asdf manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

4 participants