New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.sum file only partially updated #3017
Comments
Thanks for the detailed report. Do you know if there is any documentation from the Golang team on exactly what should be expected when a go.sum is updated? e.g. the "2 checksums"? FYI the default Renovate behaviour is that I do have an option - currently controllable via my admin settings only - to run |
I was trying to find some documentation on You're right about the root cause - I can replicate it by copying only
I do get extra line for |
I have switched your repo to use gitFs instead of API. That way the entire file system is present locally when |
Thanks, unfortunately that failed because there's I think that running on top of full sources would have other benefits - like being able to run I've raised golang/go#29492 to get some clarity on what to expect from |
@rarkins as mentioned above I can't easily take advantage of gitFS, although I appreciate enabling it for me, so maybe you want to switch it off as it makes those tasks more expensive to run? Plus when it fails with gitFS it generates a long error message. Thanks! |
@prymitive I've done that now, although I plan to switch the app over 100% to gitFs in coming months |
I'm going to close this one, as there's nothing can be done right now, e.g.
|
…om/golangci/golangci-lint@v1.21.0 Reference: renovatebot/renovate#3017
Reference: renovatebot/renovate#3017 Updated via: `go mod tidy`
* Update module aws/aws-sdk-go to v1.25.48 * deps: Add missing github.com/aws-sdk-go@v1.25.48 checksum Reference: renovatebot/renovate#3017 Updated via: `go mod tidy`
What Renovate type are you using?
Renovate GitHub App
Describe the bug
go.sum
file includes 2 checksums per dependency, example:So an updated Go module dependency should trigger a PR with 3 changes:
go.mod
go.sum
with checksumsYet for some reason I got 2 PRs that include only one new line per dependency in
go.sum
- checksum forgo.mod
, the other expected line is missing (chore(deps): update github.com/gin-contrib/cors commit hash to 5e7acb1 prymitive/karma#345 chore(deps): update github.com/gin-contrib/gzip commit hash to 0eb78e9 prymitive/karma#346).Running
go get
orgo build
on top of that PR results in missing lines being added:Did you see anything helpful in debug logs?
If you are using the Renovate App, log into https://renovatebot.com/dashboard and locate the correct job log for when the problem occurred (e.g. when the PR was created).
Nothing unexpected in the log.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Renovate PR should be complete and build without generating any git diff.
Screenshots
Additional context
I wasn't able to reproduce this issue locally with Go 1.11.4, forcing a rebase still creates a commit with only half of
go.sum
updates. Both updated dependencies were adding support for Go modules, so in both casesgo.(mod|sum)
file was added in the version those deps were being updated to, which might be a factor.The text was updated successfully, but these errors were encountered: