Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rez versioning #10930

Merged
merged 36 commits into from Sep 17, 2021
Merged

feat: Add rez versioning #10930

merged 36 commits into from Sep 17, 2021

Conversation

@skral
Copy link
Contributor

@skral skral commented Jul 22, 2021

Changes:

Add rez versioning, including tests, and documentation.

Context:

As described in discussion 10918, I am using the rez package manager and can read the package.py it uses to state dependencies with a regular expression, the versioning needed some code related changes though. This MR adds the capability to renovate to understand rez versioning.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@skral skral changed the title Feat/add rez versioning feat: Add rez versioning Jul 22, 2021
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Some initial docs changes.

lib/versioning/rez/readme.md Outdated Show resolved Hide resolved
lib/versioning/rez/readme.md Outdated Show resolved Hide resolved
lib/versioning/rez/readme.md Show resolved Hide resolved
lib/versioning/rez/readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@viceice viceice left a comment

Code otherwise LGTM so far.

lib/versioning/rez/index.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@viceice viceice left a comment

Needs lint and coverage fixes

skral and others added 7 commits Jul 28, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@skral
Copy link
Contributor Author

@skral skral commented Jul 28, 2021

Applied the docs suggestions, updated the tests to reach 100% coverage and ran prettier. Please take another look when you get a chance.

@skral skral requested review from viceice and HonkingGoose Jul 28, 2021
lib/versioning/rez/index.ts Outdated Show resolved Hide resolved
lib/versioning/rez/index.ts Outdated Show resolved Hide resolved
lib/versioning/rez/index.ts Outdated Show resolved Hide resolved
lib/versioning/rez/readme.md Outdated Show resolved Hide resolved
lib/versioning/rez/readme.md Show resolved Hide resolved
lib/versioning/rez/index.ts Outdated Show resolved Hide resolved
lib/versioning/rez/index.ts Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@viceice viceice marked this pull request as draft Jul 29, 2021
@viceice
Copy link
Collaborator

@viceice viceice commented Jul 29, 2021

Marking this as draft until we know licensing for sure

lib/versioning/rez/readme.md Outdated Show resolved Hide resolved
lib/versioning/rez/index.spec.ts Outdated Show resolved Hide resolved
@skral skral requested a review from viceice Sep 13, 2021
@HonkingGoose HonkingGoose requested a review from zharinov Sep 13, 2021
@skral
Copy link
Contributor Author

@skral skral commented Sep 13, 2021

  • Extracted the pattern and some utility functions into their own files.
  • Updated the tests to match the new style.

Please take another look when you get a chance.

@skral
Copy link
Contributor Author

@skral skral commented Sep 13, 2021

Fixed the security warnings.

lib/versioning/rez/transform.ts Show resolved Hide resolved
lib/versioning/rez/index.ts Outdated Show resolved Hide resolved
@skral
Copy link
Contributor Author

@skral skral commented Sep 16, 2021

@viceice / @zharinov, anything else for me to tackle on this one?

Copy link
Collaborator

@rarkins rarkins left a comment

Versioning on it own won't hurt anybody even if there's an undiscovered bug

@rarkins rarkins enabled auto-merge (squash) Sep 17, 2021
@rarkins rarkins requested a review from HonkingGoose Sep 17, 2021
@rarkins rarkins merged commit ea0b324 into renovatebot:main Sep 17, 2021
7 checks passed
@skral skral deleted the feat/add-rez-versioning branch Sep 17, 2021
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 17, 2021

🎉 This PR is included in version 27.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants