Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): migrate requiredStatusChecks to ignoreTests #11355

Merged
merged 11 commits into from Sep 12, 2021

Conversation

@pret-a-porter
Copy link
Contributor

@pret-a-porter pret-a-porter commented Aug 20, 2021

Changes:

  1. Introduced abstract class Migration. Now any new migration should extend it
  2. Added migration from requiredStatusChecks to ignoreTests
  3. Unit tests were aligned to changes

Context:

Fixes #11163

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@pret-a-porter pret-a-porter requested a review from JamieMagee as a code owner Aug 20, 2021
@pret-a-porter pret-a-porter force-pushed the feat/ignore-tests branch 2 times, most recently from 06d3578 to 395bd46 Aug 22, 2021
Copy link
Collaborator

@rarkins rarkins left a comment

@viceice @JamieMagee can you review if you think the migration class is the right approach going forward?

lib/workers/pr/automerge.ts Outdated Show resolved Hide resolved
@pret-a-porter pret-a-porter requested a review from rarkins Aug 23, 2021
@JamieMagee
Copy link
Collaborator

@JamieMagee JamieMagee commented Aug 23, 2021

I think it's a nice idea (I say as I'm currently migrating datasources to be classes 😅). I think it'll make them easier to write and test, as we can enforce things from the abstract Migrate class, and prevent lots of repeated boilerplate code.

lib/config/migration.ts Outdated Show resolved Hide resolved
lib/platform/types.ts Outdated Show resolved Hide resolved
lib/config/migrations/migration.ts Outdated Show resolved Hide resolved
lib/config/migration.ts Outdated Show resolved Hide resolved
lib/config/migrations/required-status-checks-migration.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@viceice viceice left a comment

See other comment

Copy link
Collaborator

@viceice viceice left a comment

Made some new suggestions, so the ignoreTests can be completly removed from platform.getBranchStatus code

lib/platform/types.ts Outdated Show resolved Hide resolved
lib/workers/branch/automerge.ts Outdated Show resolved Hide resolved
lib/workers/pr/automerge.ts Outdated Show resolved Hide resolved
lib/workers/pr/body/config-description.ts Show resolved Hide resolved
lib/workers/pr/body/config-description.ts Outdated Show resolved Hide resolved
lib/workers/pr/index.ts Outdated Show resolved Hide resolved
lib/workers/pr/index.ts Outdated Show resolved Hide resolved
lib/workers/branch/automerge.ts Show resolved Hide resolved
@pret-a-porter pret-a-porter requested a review from viceice Aug 25, 2021
Copy link
Collaborator

@viceice viceice left a comment

See my suggestions

@pret-a-porter
Copy link
Contributor Author

@pret-a-porter pret-a-porter commented Aug 28, 2021

@viceice Everything is done

@viceice
Copy link
Collaborator

@viceice viceice commented Aug 28, 2021

Please use the re-request review button. 😉

@viceice
Copy link
Collaborator

@viceice viceice commented Aug 31, 2021

@JamieMagee Any comments about the migration code? Any idea for optimizations / improvements here?

@pret-a-porter
Copy link
Contributor Author

@pret-a-porter pret-a-porter commented Sep 3, 2021

@rarkins @JamieMagee can we merge this branch? Do you expect any changes/comments from my side?

lib/workers/pr/automerge.ts Show resolved Hide resolved
lib/workers/branch/status-checks.ts Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft Sep 6, 2021
Copy link
Collaborator

@viceice viceice left a comment

needs deconflicting / snapshot updates

@pret-a-porter
Copy link
Contributor Author

@pret-a-porter pret-a-porter commented Sep 11, 2021

Deconflicted

@pret-a-porter pret-a-porter requested a review from viceice Sep 11, 2021
@JamieMagee JamieMagee marked this pull request as ready for review Sep 11, 2021
@JamieMagee
Copy link
Collaborator

@JamieMagee JamieMagee commented Sep 11, 2021

LGTM 👍

Will wait and give @viceice a chance to review.

@viceice viceice enabled auto-merge (squash) Sep 12, 2021
@viceice viceice dismissed rarkins’s stale review Sep 12, 2021

Requested changes applied

@viceice viceice merged commit 7801ae7 into renovatebot:main Sep 12, 2021
7 checks passed
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 12, 2021

🎉 This PR is included in version 27.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants