Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable pre-commit manager #11616

Merged
merged 5 commits into from Sep 9, 2021
Merged

feat: disable pre-commit manager #11616

merged 5 commits into from Sep 9, 2021

Conversation

@rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 7, 2021

Changes:

Disables pre-commit manager by default.

BREAKING CHANGE: pre-commit manager is no longer enabled by default, and must be opted into manually.

Context:

Hostility from pre-commit maintainer.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
Disables pre-commit manager by default.

BREAKING CHANGE: pre-commit manager is no longer enabled by default, and must be opted into manually.
@rarkins rarkins requested review from HonkingGoose and viceice Sep 7, 2021
rarkins and others added 2 commits Sep 7, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins requested a review from HonkingGoose Sep 7, 2021
@HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Sep 7, 2021

For anybody wanting to know why we're disabling the pre-commit manager by default, see this issue: #11166

viceice
viceice approved these changes Sep 9, 2021
@rarkins rarkins merged commit 8c9c04b into main Sep 9, 2021
8 checks passed
@rarkins rarkins deleted the breaking/pre-commit-disable branch Sep 9, 2021
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 9, 2021

🎉 This PR is included in version 27.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants