Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): scoped secrets using pgp/gpg #11673

Merged
merged 24 commits into from Sep 16, 2021
Merged

feat(config): scoped secrets using pgp/gpg #11673

merged 24 commits into from Sep 16, 2021

Conversation

@rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 10, 2021

Changes:

Adds PGP encryption.

Context:

This solves two problems in one:

  • Scoped secrets to eliminate replay attacks
  • PGP-based encryption to remove the existing line length limitations

Closes #10641

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@rarkins rarkins requested review from viceice and HonkingGoose Sep 10, 2021
Copy link
Collaborator

@viceice viceice left a comment

one question, otherwise LGTM

lib/config/decrypt.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Some initial thoughts.

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
rarkins and others added 4 commits Sep 10, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

I think we can use want instead of wish to, to simplify a bit.

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins requested review from HonkingGoose and viceice Sep 11, 2021
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

I think it looks good overall, some things we might want to fix/look at though.

docs/usage/self-hosted-configuration.md Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
@rarkins rarkins changed the title feat(config): scoped secrets using pgp feat(config): scoped secrets using pgp/gpg Sep 11, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

I'm happy with the docs now.

Copy link
Collaborator

@viceice viceice left a comment

Just some docs things, code LGTM

docs/usage/self-hosted-configuration.md Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft Sep 14, 2021
@rarkins
Copy link
Collaborator Author

@rarkins rarkins commented Sep 14, 2021

Will merge tomorrow as I need to synchronize things somewhat between docs, encrypt page, and app version

@rarkins rarkins marked this pull request as ready for review Sep 16, 2021
@rarkins rarkins enabled auto-merge (squash) Sep 16, 2021
@rarkins rarkins merged commit ee29fdc into main Sep 16, 2021
7 checks passed
@rarkins rarkins deleted the feat/10641-pgp branch Sep 16, 2021
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 16, 2021

🎉 This PR is included in version 27.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants