Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/nuget): update msbuild-sdks section in global.json #11707

Conversation

@olegkrivtsov
Copy link
Contributor

@olegkrivtsov olegkrivtsov commented Sep 13, 2021

Changes:

Nuget: update msbuild-sdks section in global.json

Context:

Closes: #8558

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@rarkins rarkins requested a review from viceice Sep 13, 2021
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@viceice viceice left a comment

Did you forgot to push your changes? You closed discussions without a code change.

lib/manager/nuget/extract.spec.ts Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Collaborator

@viceice viceice commented Sep 14, 2021

please use the github apply sugesstion feature and don't add a fixed comment to every discussion, as that makes a lot of noise.
or simply resolve the discussion when it's done. no need for a fixed comment 😉

@olegkrivtsov
Copy link
Contributor Author

@olegkrivtsov olegkrivtsov commented Sep 14, 2021

Hi @viceice please give me a few minutes, I'm pushing my changes. Just wanted to run tests and check everything is ok before pushing.

@olegkrivtsov
Copy link
Contributor Author

@olegkrivtsov olegkrivtsov commented Sep 14, 2021

@viceice I've tried to address all your suggestions. Please see my latest commit. Sorry for my mistakes, I'm just learning to be a part of open-source project 😉

Copy link
Collaborator

@viceice viceice left a comment

you missed some of my sugesstions while moving code to this file 😉

lib/manager/nuget/extract/global-manifest.ts Show resolved Hide resolved
lib/manager/nuget/extract/global-manifest.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract/global-manifest.ts Outdated Show resolved Hide resolved
olegkrivtsov and others added 4 commits Sep 14, 2021
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@olegkrivtsov
Copy link
Contributor Author

@olegkrivtsov olegkrivtsov commented Sep 14, 2021

@viceice tests pass now, and I tried to apply all suggestions. Could you please check again?

@viceice
Copy link
Collaborator

@viceice viceice commented Sep 14, 2021

Please use re-request review option next time instead of comments 😉
image

We normally ignore comments like that 🙃

@viceice
Copy link
Collaborator

@viceice viceice commented Sep 14, 2021

You can also batch all suggestions to one commit, so you don't start known failing ci jobs 😉

Copy link
Collaborator

@viceice viceice left a comment

I think those depTypes's are more appropriate

lib/manager/nuget/extract/global-manifest.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract/global-manifest.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@viceice viceice left a comment

found a 🐛 😅

lib/manager/nuget/extract/global-manifest.ts Outdated Show resolved Hide resolved
lib/manager/nuget/extract.spec.ts Outdated Show resolved Hide resolved
olegkrivtsov and others added 2 commits Sep 14, 2021
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@olegkrivtsov
Copy link
Contributor Author

@olegkrivtsov olegkrivtsov commented Sep 14, 2021

@viceice I'm sorry for the 🐛. I'm a bit new to this project and don't yeat fully understand which data should generate which test results (

@viceice viceice enabled auto-merge (squash) Sep 14, 2021
@viceice viceice merged commit 196df0d into renovatebot:main Sep 14, 2021
7 checks passed
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 14, 2021

🎉 This PR is included in version 27.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants