New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/nuget): update msbuild-sdks section in global.json #11707
feat(manager/nuget): update msbuild-sdks section in global.json #11707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forgot to push your changes? You closed discussions without a code change.
lib/manager/nuget/__fixtures__/msbuild-sdk-files/invalid-json/global.json
Outdated
Show resolved
Hide resolved
lib/manager/nuget/__fixtures__/msbuild-sdk-files/not-nuget/global.json
Outdated
Show resolved
Hide resolved
please use the github apply sugesstion feature and don't add a fixed comment to every discussion, as that makes a lot of noise. |
Hi @viceice please give me a few minutes, I'm pushing my changes. Just wanted to run tests and check everything is ok before pushing. |
@viceice I've tried to address all your suggestions. Please see my latest commit. Sorry for my mistakes, I'm just learning to be a part of open-source project 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed some of my sugesstions while moving code to this file 😉
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice tests pass now, and I tried to apply all suggestions. Could you please check again? |
You can also batch all suggestions to one commit, so you don't start known failing ci jobs 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those depTypes
's are more appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a 🐛 😅
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice I'm sorry for the 🐛. I'm a bit new to this project and don't yeat fully understand which data should generate which test results ( |
🎉 This PR is included in version 27.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Nuget: update msbuild-sdks section in global.json
Context:
Closes: #8558
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: