Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): add codemirror group #11721

Merged
merged 6 commits into from Sep 16, 2021

Conversation

@sachinraja
Copy link
Contributor

@sachinraja sachinraja commented Sep 13, 2021

Added as a pattern group because each package has a separate repository:
https://github.com/codemirror/view
https://github.com/codemirror/state
https://github.com/codemirror/lang-javascript

and so on.

Copy link
Collaborator

@viceice viceice left a comment

I don't think this makes sense, as it's not a monorepo. They also have different releases.

@rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 14, 2021

If they are released synchronously and must be updated together, then we use a monorepo group.
If they are not released synchronously but usually need to be updated at the same time and the Renovate community would benefit from this being done automatically then then can be put in group:recommended.

Otherwise if this is just an opinionated grouping/personal preference then it's best to configure it locally and not add it to Renovate.

@sachinraja
Copy link
Contributor Author

@sachinraja sachinraja commented Sep 14, 2021

They are not exactly released synchronously but a minor version bump will usually result in an update for all the other packages because they have hard dependencies on each other:

For example, if I install @codemirror/view and @codemirror/state, @codemirror/view has a dependency on @codemirror/state in the range ^0.19.2: https://github.com/codemirror/view/blob/c0be0ebe935ec6b821e5f92c087c208b9b8cdbfe/package.json#L30. If @codemirror/state gets a minor version bump to ^0.2.0 and @codemirror/view gets a minor version bump to ^0.2.0 to update it and I only update @codemirror/view, then deduping cannot happen. Ending up with two versions of it will likely cause problems. That being said, I'm not sure if it is planned to independently version them or if they are just updating because of the hard dependencies. I could ask if necessary.

So I'm not sure if this should be put in the monorepo group or group:recommended.

@viceice
Copy link
Collaborator

@viceice viceice commented Sep 14, 2021

This is not a mono repo and the updates don't need to be grouped. dedupe is not a issue for renovate here.

So i think this should be done per use case and not by default in any renovate preset.

@viceice viceice closed this Sep 14, 2021
@sachinraja
Copy link
Contributor Author

@sachinraja sachinraja commented Sep 14, 2021

The app can break if the dependencies are not updated together though because deduping is actually necessary sometimes, for example, see codemirror/codemirror.next#503 (comment).

@rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 14, 2021

@viceice sounds like they've had enough problems that we could group by default. I'd go with group:recommended

@viceice
Copy link
Collaborator

@viceice viceice commented Sep 14, 2021

ok, so @sachinraja please apply the grouping to group:recommended

like this

jekyllEcosystem: {
description: 'Group jekyll and related ruby packages together',
packageRules: [
{
matchSourceUrlPrefixes: [
'https://github.com/jekyll/',
'https://github.com/github/pages-gem',
],
groupName: 'jekyll ecosystem packages',
},
],
},

'group:jekyllEcosystem',

@viceice viceice reopened this Sep 14, 2021
@viceice viceice marked this pull request as draft Sep 14, 2021
@sachinraja sachinraja changed the title feat(preset): add codemirror monorepo feat(preset): add codemirror group Sep 14, 2021
@sachinraja sachinraja marked this pull request as ready for review Sep 14, 2021
@rarkins rarkins enabled auto-merge (squash) Sep 15, 2021
lib/config/presets/internal/group.ts Outdated Show resolved Hide resolved
auto-merge was automatically disabled Sep 15, 2021

Head branch was pushed to by a user without write access

@sachinraja sachinraja requested a review from viceice Sep 15, 2021
@viceice viceice enabled auto-merge (squash) Sep 16, 2021
@viceice viceice merged commit f291635 into renovatebot:main Sep 16, 2021
7 checks passed
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 16, 2021

🎉 This PR is included in version 27.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sachinraja sachinraja deleted the add-codemirror-monorepo branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants