Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): put typed platform rule first #11722

Merged
merged 1 commit into from Sep 14, 2021
Merged

Conversation

@rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 14, 2021

Changes:

Reorders platform hostRules

Context:

Closes #11710

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@rarkins rarkins requested a review from viceice Sep 14, 2021
Copy link
Collaborator

@viceice viceice left a comment

Did you verified that this will fix the issue? i think we apply all matching rules, so the untyped will applied anyways?

@rarkins
Copy link
Collaborator Author

@rarkins rarkins commented Sep 14, 2021

Basing this fix off #11710 (comment)

@rarkins rarkins merged commit 2d99e76 into main Sep 14, 2021
8 checks passed
@rarkins rarkins deleted the fix/11710-platform-rule branch Sep 14, 2021
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 14, 2021

🎉 This PR is included in version 27.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uncycler uncycler mentioned this pull request Sep 15, 2021
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants