Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker/branch): optimize artifact error handling #11771

Merged
merged 6 commits into from Sep 17, 2021
Merged

Conversation

@viceice
Copy link
Collaborator

@viceice viceice commented Sep 16, 2021

Changes:

  • set artifact commit status early
  • do not break early on artifact error

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@viceice viceice requested a review from rarkins Sep 16, 2021
lib/workers/branch/index.ts Outdated Show resolved Hide resolved
@viceice viceice requested a review from rarkins Sep 16, 2021
@rarkins rarkins enabled auto-merge (squash) Sep 17, 2021
@rarkins rarkins merged commit d3c9fd5 into main Sep 17, 2021
7 checks passed
@rarkins rarkins deleted the fix/artifact-error branch Sep 17, 2021
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 17, 2021

🎉 This PR is included in version 27.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants