Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency-dashboard): Adjust dry run log output #11820

Merged
merged 3 commits into from Sep 20, 2021

Conversation

@Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Sep 20, 2021

Changes:

This PR slightly adjusts the dry run log output for the dependency dashboard, which is currently a little confusing.

Context:

The log output is currently:

INFO: DRY-RUN: Would ensure Dependency Dashboard Dependency Dashboard (repository=npm-packages/ember-template-lint-plugin-qonto)

and the "Dependency Dashboard Dependency Dashboard" part appears a little confusing. This PR should fix it by making it at least a little clearer that the second "Dependency Dashboard" could be the title of the issue.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@Turbo87 Turbo87 changed the title dependency-dashboard: Adjust dry run log output chore(dependency-dashboard): Adjust dry run log output Sep 20, 2021
@viceice viceice requested a review from rarkins Sep 20, 2021
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice changed the title chore(dependency-dashboard): Adjust dry run log output fix(dependency-dashboard): Adjust dry run log output Sep 20, 2021
@Turbo87
Copy link
Contributor Author

@Turbo87 Turbo87 commented Sep 20, 2021

sorry, I just noticed that there was more than one logging call in that file 😅

@rarkins rarkins merged commit 786bd4e into renovatebot:main Sep 20, 2021
8 checks passed
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 20, 2021

🎉 This PR is included in version 27.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants