Skip to content

Conversation

@jycamier
Copy link
Contributor

@jycamier jycamier commented May 3, 2022

Changes

The helmfile manager need to use docker datasource when it deals with OCI repository like :

repositories:
  - name: jycamier
    url: ghcr.io/jycamier/renovate-helmfile-oci-reproduction-app
    oci: true

releases:
  - name: app-test
    chart: jycamier/oci-chart-test
    version: 0.1.0

Context

Close #13656

Documentation

  • I have updated the documentation, or
  • No documentation update is required

The oci: true is a helmfile native attribute.

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The real repository is https://github.com/jycamier/renovate-helmfile-oci-reproduction.
You can see the pull request here : https://github.com/jycamier/renovate-helmfile-oci-reproduction/pull/2

@CLAassistant
Copy link

CLAassistant commented May 3, 2022

CLA assistant check
All committers have signed the CLA.

@viceice viceice changed the title chore(helmfile): oci support for helmfile feat(helmfile): oci support for helmfile May 3, 2022
@viceice viceice changed the title feat(helmfile): oci support for helmfile feat(helmfile): oci support May 3, 2022
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests

@viceice
Copy link
Member

viceice commented May 3, 2022

and git author/ committer fix (use force push to update)

@jycamier jycamier force-pushed the feat/helmfile-oci-support branch from 7e4b5ff to c10ff95 Compare May 3, 2022 19:10
@jycamier jycamier force-pushed the feat/helmfile-oci-support branch from c10ff95 to d4a7221 Compare May 3, 2022 19:56
@jycamier
Copy link
Contributor Author

jycamier commented May 3, 2022

Thank you @viceice
I think it's good !

@jycamier jycamier force-pushed the feat/helmfile-oci-support branch from 32ee00c to cd6d4c6 Compare May 4, 2022 13:37
@jycamier
Copy link
Contributor Author

jycamier commented May 4, 2022

And my tests are succeed now.

@jycamier jycamier force-pushed the feat/helmfile-oci-support branch from 3ebb339 to 984e556 Compare May 5, 2022 07:17
@rarkins rarkins requested a review from viceice May 5, 2022 08:08
@jycamier jycamier force-pushed the feat/helmfile-oci-support branch from e72bc90 to 2bd367f Compare May 5, 2022 09:09
@rarkins rarkins enabled auto-merge (squash) May 5, 2022 09:17
rarkins
rarkins previously approved these changes May 5, 2022
auto-merge was automatically disabled May 5, 2022 09:45

Head branch was pushed to by a user without write access

@jycamier jycamier force-pushed the feat/helmfile-oci-support branch from d9560c9 to 7adcc33 Compare May 5, 2022 09:45
@jycamier jycamier requested a review from rarkins May 5, 2022 09:51
@rarkins rarkins enabled auto-merge (squash) May 5, 2022 11:51
@rarkins rarkins disabled auto-merge May 5, 2022 12:15
@rarkins rarkins merged commit e97974d into renovatebot:main May 5, 2022
@renovate-release
Copy link

🎉 This PR is included in version 32.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for OCI registries in helmfile

5 participants