feat(telemetry): add OpenTelemetry tracing MVC #15731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shegox
reviewed
May 25, 2022
Co-authored-by: Anne Stellingwerf <astellin@opentext.com>
JamieMagee
reviewed
May 27, 2022
JamieMagee
reviewed
May 27, 2022
rarkins
reviewed
May 27, 2022
JamieMagee
reviewed
May 27, 2022
astellingwerf
suggested changes
May 29, 2022
Collaborator
astellingwerf
left a comment
astellingwerf
left a comment
There was a problem hiding this comment.
docs/usage/examples/opentelemetry.md is good to have, I think. It helps to get more insight in what we'd gain with it.
Changes binarySource default value from global to install. Closes renovatebot#14531 BREAKING CHANGE: Users of containerbase images (such as official Renovate images) will now have dynamic package manager installs enabled by default.
Removes support for Node 14 as a runtime for Renovate. BREAKING CHANGE: Node 16 is the required runtime for Renovate.
Unifies CLI and env coercions. BREAKING CHANGE: boolean variables must be true or false when configured in env, and errors will be thrown for invalid values. Previously invalided values were ignored and treated as false.
Removes forkMode setting and instead relies on forkToken alone to indicate forking mode is active. Additionally, defines forkToken as an experimental setting. BREAKING CHANGE: No longer necessary to configure forkMode. Forking mode is now experimental.
Closes renovatebot#15818 BREAKING CHANGE: azure-pipelines manager is now disabled by default.
…atebot#14525) Use absolute import format for depName in jsonnet-bundler. Closes renovatebot#13568 BREAKING CHANGE: `depName` now uses the "absolute import" format (e.g. `bar` → `github.com/foo/bar/baz-wow`)
Removes all logic where rangeStrategy=auto results in pinning. Closes renovatebot#18304 BREAKING CHANGE: Dependencies are no longer automatically pinned, pinning must be opted into using rangeStrategy=pin
viceice
reviewed
Oct 19, 2022
JamieMagee
reviewed
Oct 20, 2022
JamieMagee
approved these changes
Oct 20, 2022
viceice
reviewed
Oct 20, 2022
viceice
reviewed
Oct 22, 2022
viceice
reviewed
Oct 22, 2022
viceice
approved these changes
Oct 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implements a minimal implementation of OpenTelemetry tracing.
Some manual spans are created and following instrumentations are added and activated:
Auto trace http(s) requests
Add traceId and spanId to structured logs
Later additional manual and automatic instrumentations can be added e.g.:
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: