Skip to content

feat(datasource/azure-pipelines-tasks): Adds support for the Azure DevOps Marketplace #19692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 7, 2023
Merged

feat(datasource/azure-pipelines-tasks): Adds support for the Azure DevOps Marketplace #19692

merged 12 commits into from
Jan 7, 2023

Conversation

jessehouwing
Copy link
Contributor

@jessehouwing jessehouwing commented Jan 5, 2023

Changes

Adds support for Azure DevOps Marketplace
Fetches marketplace data from https://github.com/jessehouwing/renovate-azure-devops-marketplace which refreshes daily

Context

Renovate currently doesn't support the non-built-in tasks. My own security research shows how many older tasks have significant issues and conversations with admins shows it's very hard for admins to ensure the latest versions of tasks are used.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

@jessehouwing jessehouwing changed the title Add support for the Azure DevOps Marketplace for Azure Pipelines Adds support for the Azure DevOps Marketplace for Azure Pipelines Jan 5, 2023
@jessehouwing jessehouwing changed the title Adds support for the Azure DevOps Marketplace for Azure Pipelines feat: Adds support for the Azure DevOps Marketplace for Azure Pipelines Jan 5, 2023
@JamieMagee
Copy link
Contributor

Overall this looks good. We might just want to migrate your script into this repo directly, but I don't see this as a blocker for now.

Snehasish86
Snehasish86 previously approved these changes Jan 7, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@jessehouwing
Copy link
Contributor Author

Overall this looks good. We might just want to migrate your script into this repo directly, but I don't see this as a blocker for now.

The script caches all extension an task manifests to speed things up. Which was way more data than I thought, I'd be willing to transfer this repo to the renovate org after cleaning it up a bit more though. I have a few ideas to speed up the update process (which currently takes about 10 to 15 minutes for each run).

Without the cache the update takes more than 24h as-is and transfers about 650GB of data.

The cache stores the minimum files to be able to cleanly regenerate the renovate-data file, but still adds almost 100k files to the repo and slows things down considerably.

image

My recommendation: bring the repo into the renovate org, but keep it separate from the main renovate repo. Or I need to refactor it a bit to stick the cache into a separate repo and update that from the workflow.

To run the updater, you also need to configure an Azure DevOps Marketplace PAT with Marketplace (Read) permissions stored as a GitHub Actions Secret.

@JamieMagee
Copy link
Contributor

Wow 👀 I didn't realise it was such a large amount of data.

That sounds like a good suggestion. We can create a followup issue to do that after this PR is merged.

@rarkins rarkins requested a review from viceice January 7, 2023 08:33
@jessehouwing
Copy link
Contributor Author

I hadn't anticipated that either when I got started :o).

@viceice viceice enabled auto-merge (squash) January 7, 2023 08:42
@viceice viceice disabled auto-merge January 7, 2023 08:42
@viceice viceice changed the title feat: Adds support for the Azure DevOps Marketplace for Azure Pipelines feat(datasource/azure-pipeline-tasks): Adds support for the Azure DevOps Marketplace Jan 7, 2023
@viceice viceice changed the title feat(datasource/azure-pipeline-tasks): Adds support for the Azure DevOps Marketplace feat(datasource/azure-pipelines-tasks): Adds support for the Azure DevOps Marketplace Jan 7, 2023
@viceice viceice enabled auto-merge (squash) January 7, 2023 08:43
@viceice viceice merged commit 8281e1a into renovatebot:main Jan 7, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.92.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JamieMagee JamieMagee linked an issue Jan 8, 2023 that may be closed by this pull request
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the Azure DevOps Marketplace tasks
7 participants