From b2ddf03884e91be9e48035911f44fa970cb2e99b Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Tue, 12 Sep 2023 06:24:19 +0200 Subject: [PATCH 1/3] fix(presets): use dash instead of spaces --- lib/config/presets/internal/monorepo.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/presets/internal/monorepo.ts b/lib/config/presets/internal/monorepo.ts index 81fa1253d41af2..2c391c4505c87c 100644 --- a/lib/config/presets/internal/monorepo.ts +++ b/lib/config/presets/internal/monorepo.ts @@ -34,7 +34,7 @@ const repoGroups = { 'arcus.webapi': 'https://github.com/arcus-azure/arcus.webapi', 'aspnet aspnetwebstack': 'https://github.com/aspnet/AspNetWebStack', 'aspnet extensions': 'https://github.com/aspnet/Extensions', - 'aspnet health checks': + 'aspnet-health-checks': 'https://github.com/xabaril/AspNetCore.Diagnostics.HealthChecks', 'aspnet-api-versioning': 'https://github.com/Microsoft/aspnet-api-versioning', 'automapper-dotnet': [ From e24d2f37b1839da09f9679729a6e5c34326fee7e Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Tue, 12 Sep 2023 06:36:39 +0200 Subject: [PATCH 2/3] Apply suggestions from code review --- lib/config/presets/internal/monorepo.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/presets/internal/monorepo.ts b/lib/config/presets/internal/monorepo.ts index 2c391c4505c87c..b9c99cd663cca6 100644 --- a/lib/config/presets/internal/monorepo.ts +++ b/lib/config/presets/internal/monorepo.ts @@ -34,9 +34,9 @@ const repoGroups = { 'arcus.webapi': 'https://github.com/arcus-azure/arcus.webapi', 'aspnet aspnetwebstack': 'https://github.com/aspnet/AspNetWebStack', 'aspnet extensions': 'https://github.com/aspnet/Extensions', + 'aspnet-api-versioning': 'https://github.com/Microsoft/aspnet-api-versioning', 'aspnet-health-checks': 'https://github.com/xabaril/AspNetCore.Diagnostics.HealthChecks', - 'aspnet-api-versioning': 'https://github.com/Microsoft/aspnet-api-versioning', 'automapper-dotnet': [ 'https://github.com/AutoMapper/AutoMapper', 'https://github.com/AutoMapper/AutoMapper.Extensions.Microsoft.DependencyInjection', From 686c133e9560d37d0ced9381c28167ef0839ec48 Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Tue, 12 Sep 2023 06:47:51 +0200 Subject: [PATCH 3/3] test: add monorepo name validation --- lib/config/presets/internal/monorepo.spec.ts | 26 ++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 lib/config/presets/internal/monorepo.spec.ts diff --git a/lib/config/presets/internal/monorepo.spec.ts b/lib/config/presets/internal/monorepo.spec.ts new file mode 100644 index 00000000000000..87883c39b368bf --- /dev/null +++ b/lib/config/presets/internal/monorepo.spec.ts @@ -0,0 +1,26 @@ +import { presets } from './monorepo'; + +const todo = new Set([ + 'arcus.background-jobs', + 'arcus.event-grid', + 'arcus.messaging', + 'arcus.observability', + 'arcus.security', + 'arcus.webapi', + 'aspnet aspnetwebstack', + 'aspnet extensions', + 'azure azure-libraries-for-net', + 'azure azure-sdk-for-net', + 'azure azure-storage-net', + 'Hangfire', + 'system.io.abstractions', + 'vaadinWebComponents', +]); + +describe('config/presets/internal/monorepo', () => { + it('presets should have right name', () => { + for (const name of Object.keys(presets).filter((name) => !todo.has(name))) { + expect(name).toMatch(/^[a-z0-9-]+$/); + } + }); +});