Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with Replay being unlocked in 6.17 #356

Closed
renpytom opened this issue May 11, 2014 · 9 comments
Closed

issues with Replay being unlocked in 6.17 #356

renpytom opened this issue May 11, 2014 · 9 comments

Comments

@renpytom
Copy link
Member

renpytom commented May 11, 2014

http://lemmasoft.renai.us/forums/viewtopic.php?f=32&t=26521

@dobacco
Copy link

dobacco commented May 17, 2014

I'm having the same problem when testing out a game that used 6.15 and worked perfectly fine and moving it to 6.17 with replay functions broken, if I revert commit e6b8304 replay works as expected.

edit: game in question is fault milestone one, I can provide samples if needed in private.

edit2: I also tried setting locked to false without reverting the commit and while the things are clickable, the replay doesn't fire off and show the scene.

@renpytom
Copy link
Member Author

renpytom commented May 19, 2014

Have you check if renpy.seen_label is properly reporting the label in question as seen?

@dobacco
Copy link

dobacco commented May 19, 2014

I'm not that familiar enough with Ren'py to know what that means, is there
docs about it? Sorry.
On May 19, 2014 10:08 PM, "Tom Rothamel" notifications@github.com wrote:

Have you check if renpy.seen_label is properly reporting the label in
question as seen?


Reply to this email directly or view it on GitHubhttps://github.com//issues/356#issuecomment-43499615
.

@renpytom
Copy link
Member Author

renpytom commented May 19, 2014

What I need you to do is add to your game code like:

$ locked = renpy.seen_label("my_label")
"my_label = [locked]"

where my_label is the label you're starting replay at.

@dobacco
Copy link

dobacco commented May 20, 2014

Sorry, seems like the issue was something else, I noticed this after I dug around some more. The original script was calling the movie files directly instead of the label. So my report is invalid for this case, thanks for the help.

@renpytom renpytom closed this as completed Jul 8, 2014
@LordMune
Copy link

LordMune commented Oct 10, 2014

Original issue (locked=False not working) persists in 6.18. Can this be reopened?

@renpytom renpytom reopened this Oct 10, 2014
@renpytom
Copy link
Member Author

renpytom commented Oct 15, 2014

LordMune, can you give me a replication of some sort?

@LordMune
Copy link

LordMune commented Oct 15, 2014

I'm afraid not, because I can't replicate it anymore. Which is good, but I feel pretty dumb. I did update ren'py since last I tried (from 6.18.something to 6.18.2.729), and it works fine now after uncommenting the relevant lines. Sorry about that...

@LordMune
Copy link

LordMune commented Oct 16, 2014

Correction, got a couple of lines mixed up. locked=None works as intended, but locked=False will always be locked.

textbutton "Replay Earth Room if seen" action Replay("earthroomoptions", locked=None)
textbutton "Always replay Earth Room" action Replay("earthroomoptions", locked=False)

In this case "Always replay Earth Room" remains locked, even as "Replay Earth Room if seen" unlocks correctly (and the replay itself works fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants