Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IMG_SavePNG* to avoid conflict with PygameSDL2's #1608

merged 1 commit into from Oct 29, 2018


Copy link

@Beuc Beuc commented Oct 28, 2018

The conflict appears when linking statically, which I do when working on the emscripten port.
(dynamic linking is partially supported in emscripten but not in our case, and it also introduces a performance penalty.)

The 2 functions sets are not exactly the same and do not have the same signatures, hence why I didn't merge them. Note: there is a 3rd set of IMG_SavePNG functions in SDL2_image.

@renpytom renpytom merged commit 10e3acf into renpy:master Oct 29, 2018
@Beuc Beuc deleted the Beuc:patch-1 branch Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.