New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to French translation #1625

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@Beuc
Contributor

Beuc commented Nov 7, 2018

I couldn't find the central point for the translations though. These strings also appear in "Tutorial" and to some extent in "Launcher". Should I replicate the changes there as well?

@renpytom renpytom merged commit 2e2f2ea into renpy:master Nov 8, 2018

@renpytom

This comment has been minimized.

Member

renpytom commented Nov 8, 2018

Merged. Yes, the changes have to be replicated 3 times.

@Alexandre-T

This comment has been minimized.

Contributor

Alexandre-T commented Nov 8, 2018

Le mot rembobinage est un bien meilleur choix que ce que j'avais proposé. Je pense que tu peux le répliquer. Je pense préférable d'utiliser des mots-clés comme : Sens, Rembobinage et Avance rapide. L'analogie avec les lecteurs vidéo est excellente. En revanche, «Rembobinage côté» n'est pas français. «Rembobinage» suffirait. À la rigueur «Sens du rembobinage». Dans tous les cas, c'est un meilleur choix que "Rollback"

The "Rembobinage" word is a better word than "Rollback". Some word like "Sens, Rembobinage, Avance rapide" could be used. But, "Rembobinage côté" isn't french. "Remboninage" is enough. "Sens du rembobinage" could be accepted. But "Rembobinage" is still a better choice than "Rollback".

@Beuc

This comment has been minimized.

Contributor

Beuc commented Nov 8, 2018

Hi Alexandre and thanks for your input,

"Sens" (way/direction) wouldn't be accurate because we're talking about which side ("côté") of the screen becomes active to perform a rollback - useful on mobile devices with no mousewheel.
In both cases this is a rollback, not a fast-forward (no "avance rapide").

"Rembobinage côté" is a compromise between accuracy and space constraints. It's used in the preferences screen that shows this block:

Rembobinage côté:
- Désactivé
- Gauche
- Droit

The full sentence (prompt + chosen value) becomes e.g. "Rembobinage coté droit" which is French.
This is not perfect but this manages to convey that "side" part, which is important to understand what this option is about.
What do you think?

@renpytom

This comment has been minimized.

Member

renpytom commented Nov 8, 2018

Please make sure I find out (probably via a new Pull Request) if this needs to be changed.

@Beuc

This comment has been minimized.

Contributor

Beuc commented Nov 9, 2018

Sure.
If there's no objection I'll replicate the patch for tutorial/launcher in a new pull request this week-end.

@Alexandre-T

This comment has been minimized.

Contributor

Alexandre-T commented Nov 10, 2018

Your solution seems to be the best one.

@Beuc Beuc deleted the Beuc:patch-4 branch Nov 10, 2018

@Beuc

This comment has been minimized.

Contributor

Beuc commented Nov 10, 2018

Done, see #1630 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment