New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw_video: use consistent platform testing #1698

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@Beuc
Copy link
Contributor

Beuc commented Jan 23, 2019

While experimenting with Emscripten, which is flagged as 'mobile', I saw a discrepancy between this patched test (renpy.mobile), and

renpy/renpy/audio/audio.py

Lines 722 to 725 in 92e0375

if renpy.android and renpy.config.hw_video and name == "movie":
c = AndroidVideoChannel(name, default_loop=loop, file_prefix=file_prefix, file_suffix=file_suffix)
elif renpy.ios and renpy.config.hw_video and name == "movie":
c = IOSVideoChannel(name, default_loop=loop, file_prefix=file_prefix, file_suffix=file_suffix)
(renpy.android or renpy.ios).
So I changed the test to only reference platforms with explicit video hardware support, rather than all mobile platforms.
Not high-priority though :)

@renpytom renpytom merged commit fde8dac into renpy:master Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment