Permalink
Browse files

Fix newly identified build warnings.

Signed-off-by: Jonathan 'Wolf' Rentzsch <jwr.git@redshed.net>
  • Loading branch information...
1 parent cf6dfbb commit 69c0083117174d05b69a62c164fc1779e5fc55b0 @lapcat lapcat committed with Feb 21, 2009
Showing with 6 additions and 7 deletions.
  1. +1 −1 Plugin/CTFMenubarMenuController.h
  2. +3 −3 Plugin/CTFMenubarMenuController.m
  3. +1 −1 Plugin/CTFUtilities.h
  4. +1 −2 Plugin/CTFsIFRSupport.m
@@ -33,7 +33,7 @@ extern NSString* kCTFLoadAllFlashViews;
extern NSString* kCTFLoadFlashViewsForWindow;
extern NSString* kCTFLoadInvisibleFlashViewsForWindow;
-extern NSUInteger maxInvisibleDimension;
+extern NSInteger maxInvisibleDimension;
@interface CTFMenubarMenuController : NSObject {
@@ -33,7 +33,7 @@ of this software and associated documentation files (the "Software"), to deal
NSString* kCTFLoadFlashViewsForWindow = @"CTFLoadFlashViewsForWindow";
NSString* kCTFLoadInvisibleFlashViewsForWindow = @"CTFLoadInvisibleFlashViewsForWindow";
-NSUInteger maxInvisibleDimension = 8;
+NSInteger maxInvisibleDimension = 8;
static NSString* kApplicationsToInstallMenuInto[] = {
@@ -85,7 +85,7 @@ - (int) applicationMenuPrefsInsertionLocation
if( indx ) {
insertLocation = [ indx intValue ];
} else {
- int showPrefsItem = -1, lastSeenSep = -1;
+ int showPrefsItem = -1;
int i;
for( i = 0 ; i < count ; ++i ) {
// Put it before the first separator after the preferences item.
@@ -227,7 +227,7 @@ - (BOOL) _flashViewExistsForKeyWindowWithInvisibleOnly: (BOOL) mustBeInvisible
NSHashEnumerator enumerator = NSEnumerateHashTable( _views );
CTFClickToFlashPlugin* item;
- while( item = NSNextHashEnumeratorItem( &enumerator ) ) {
+ while( ( item = NSNextHashEnumeratorItem( &enumerator ) ) ) {
if( [ item window ] == keyWindow ) {
if( !mustBeInvisible || [ item isConsideredInvisible ] ) {
rslt = YES;
View
@@ -30,5 +30,5 @@ THE SOFTWARE.
#define CTFForEachObject( Type, varName, container ) \
NSEnumerator* feoEnum_##__LINE__ = [ container objectEnumerator ]; \
Type* varName; \
- while( varName = [ feoEnum_##__LINE__ nextObject ] )
+ while( ( varName = [ feoEnum_##__LINE__ nextObject ] ) )
View
@@ -108,8 +108,7 @@ - (BOOL) _isSIFRText: (NSDictionary*) arguments
NSString* classValue = [[arguments objectForKey: WebPlugInAttributesKey] objectForKey: @"class"];
NSString* sifrValue = [[arguments objectForKey: WebPlugInAttributesKey] objectForKey: @"sifr"];
- if ([classValue isEqualToString: @"sIFR-flash"] || (sifrValue && [sifrValue boolValue]))
- return YES;
+ return [classValue isEqualToString: @"sIFR-flash"] || (sifrValue && [sifrValue boolValue]);
}
@end

0 comments on commit 69c0083

Please sign in to comment.