Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

[FIX] Work-around MATrackingArea 10.4 GC incompatiblity.

  • Loading branch information...
commit f027c415cadd1dada95017e57fc117c55152199c 1 parent 3674219
@rentzsch authored
Showing with 18 additions and 1 deletion.
  1. +18 −1 MATrackingArea/MATrackingArea.h
View
19 MATrackingArea/MATrackingArea.h
@@ -66,7 +66,24 @@ typedef unsigned int MATrackingAreaOptions;
@private
NSRect _rect;
MATrackingAreaOptions _options;
- __weak id _owner;
+ /*
+ Work-around: __weak breaks under ClickToFlash's specific environment:
+
+ * 10.5-or-later Base SDK (GC-aware)
+ * -fobjc-gc (GC supported but not required)
+ * 10.4 deployment target (MACOSX_DEPLOYMENT_TARGET=10.4)
+
+ The problem is 10.5 SDK + -fobjc-gc settings means function calls
+ such as _objc_assign_weak are emitted, but don't actually exist on
+ 10.4. We die with an "Symbol not found" dyld error.
+
+ We work-around this by commenting-out __weak. In the general case
+ this is a too-broad work-around, but is fine for ClickToFlash's
+ specific case: we only use MATrackingArea when NSTrackingArea isn't
+ available. That means we only use MATrackingArea on 10.4, and 10.4
+ doesn't support GC anyways.
+ */
+ /*__weak*/ id _owner;
NSDictionary * _userInfo;
NSPoint _lastMovedPoint;
BOOL _inside;
Please sign in to comment.
Something went wrong with that request. Please try again.