Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Enhancement] Split the generated fetch request method #213

Closed
pbtura opened this Issue Jun 26, 2014 · 4 comments

Comments

Projects
None yet
3 participants

pbtura commented Jun 26, 2014

Currently, the code generation for CoreData fetch requests generates a single method for each fetch that handles building and executing the query. This makes it very difficult to override the fetch request behavior in the subclass. My suggestion is to split the generated method for each fetch into two methods, one that build and returns the NSFetchRequest and the other that takes an existing request and executes it.

@rentzsch rentzsch added the accepted label Jun 26, 2014

pbtura commented Jun 26, 2014

I'll see what I can do. What classes would I need to look at to change how the fetch requests get generated?

pbtura commented Jul 14, 2014

Sorry that took so long, but this is the first chance I've had to actually
work on the problem. The changes needed turned out to be pretty simple,
just some minor modifications to the .motemplate files in the templates
directory. The pull request should be up now, take a look when you get a
chance and let me know what you think.

On Thu, Jun 26, 2014 at 5:11 PM, rentzsch notifications@github.com wrote:

I agree. Toss me a Pull Request?
https://github.com/rentzsch/mogenerator/blob/master/CONTRIBUTING.md


Reply to this email directly or view it on GitHub
#213 (comment)
.

Collaborator

justin commented Mar 22, 2016

We are declaring pull request and issue 0 now that 1.3 is out. If this is still an issue you'd like to see address with 1.30 and going forward, please open a new issue so we can start a fresh discussion. Thank you!

@justin justin closed this Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment