Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix generated transformed property statements #130

Closed
wants to merge 1 commit into from

2 participants

@nerdery-isaac

Inserting space after type "id" so that the @property statements generated for transformed properties are correct.

@nerdery-isaac nerdery-isaac Fix generated transformed property statements
Inserting space after type "id" so that the @property statements generated for transformed properties are correct.
d303358
@rentzsch
Owner

Hmm, I don't see the problem here -- mogenerator's test/ dir covers the transformable property case and it's passing the tests. Have you tried v1.27?

@nerdery-isaac

I didn't check thoroughly, but at least in the instance where I first noticed the issue, it looks like the problem still exists in 1.27. Having value as a transformable attribute results in

@property (nonatomic, strong) idvalue;

(missing the necessary space between id and value) in the private header.

@rentzsch
Owner

I don't know what to say -- test/ has Parent.myTransformableSansClassName which seems to cover this case and and it's being correctly generated. I need a repro on this in order to move forward.

@nerdery-isaac

Apparently, it was an issue with the template files, not with mogenerator itself—when I replaced my local copies of the template files, the problem went away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 26, 2012
  1. @nerdery-isaac

    Fix generated transformed property statements

    nerdery-isaac authored
    Inserting space after type "id" so that the @property statements generated for transformed properties are correct.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  mogenerator.m
View
2  mogenerator.m
@@ -359,7 +359,7 @@ - (NSString*)objectAttributeType {
} else if ([result rangeOfString:@"<"].location != NSNotFound) {
// `id<Protocol1,Protocol2>` (don't append asterisk).
} else if ([result isEqualToString:@"NSObject"]) {
- result = @"id";
+ result = @"id ";
} else {
result = [result stringByAppendingString:@"*"]; // Make it a pointer.
}
Something went wrong with that request. Please try again.