From a0f14b8f4da5c1f1d6660dcfe5feb2e791e49580 Mon Sep 17 00:00:00 2001 From: Mattt Zmuda Date: Wed, 10 Apr 2024 03:59:17 -0700 Subject: [PATCH 1/5] Update to actions/checkout@v4 --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 74995fc..dbcb125 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: node-version: [18.x, 20.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v3 with: @@ -36,7 +36,7 @@ jobs: tarball-name: ${{ steps.pack.outputs.tarball-name }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Use Node.js uses: actions/setup-node@v3 with: @@ -67,7 +67,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/download-artifact@v3 with: name: package-tarball @@ -95,7 +95,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/download-artifact@v3 with: name: package-tarball @@ -125,7 +125,7 @@ jobs: suite: [cloudflare-worker] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/download-artifact@v3 with: name: package-tarball @@ -154,7 +154,7 @@ jobs: suite: [bun] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/download-artifact@v3 with: name: package-tarball From bba6ec07a3c1a5b782ffe911d8807ef2b03fdb97 Mon Sep 17 00:00:00 2001 From: Mattt Zmuda Date: Wed, 10 Apr 2024 04:07:49 -0700 Subject: [PATCH 2/5] Use actions/setup-node@v4 --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dbcb125..9adb733 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: "npm" @@ -38,7 +38,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: 20.x cache: "npm" @@ -72,7 +72,7 @@ jobs: with: name: package-tarball - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: "npm" @@ -100,7 +100,7 @@ jobs: with: name: package-tarball - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: "npm" @@ -130,7 +130,7 @@ jobs: with: name: package-tarball - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: "npm" From 9679a792edc8a0248fc80c87e2c8bb4c0512189b Mon Sep 17 00:00:00 2001 From: Mattt Zmuda Date: Wed, 10 Apr 2024 04:09:42 -0700 Subject: [PATCH 3/5] Add missing node-version value to integration-browser --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9adb733..2144cbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -90,6 +90,7 @@ jobs: strategy: matrix: + node-version: [20.x] browser: ["chromium", "firefox", "webkit"] suite: ["browser"] fail-fast: false From 8b19ff03c13843549a9e730aab0761dc33f7d4c1 Mon Sep 17 00:00:00 2001 From: Mattt Zmuda Date: Wed, 10 Apr 2024 04:10:20 -0700 Subject: [PATCH 4/5] npm i --save-dev nock@beta --- package-lock.json | 9 ++++----- package.json | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1eb7db5..caab4f7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14,7 +14,7 @@ "@typescript-eslint/eslint-plugin": "^5.56.0", "cross-fetch": "^3.1.5", "jest": "^29.6.2", - "nock": "^14.0.0-beta.4", + "nock": "^14.0.0-beta.5", "publint": "^0.2.7", "ts-jest": "^29.1.0", "typescript": "^5.0.2" @@ -4077,12 +4077,11 @@ "dev": true }, "node_modules/nock": { - "version": "14.0.0-beta.4", - "resolved": "https://registry.npmjs.org/nock/-/nock-14.0.0-beta.4.tgz", - "integrity": "sha512-N9GIOnNFas/TtdCQpavpi6A6SyVVInkD/vrUCF2u51vlE2wSnqfPifVli6xSX8l6Lz/3sdSwPusE9n3KPDDh0g==", + "version": "14.0.0-beta.5", + "resolved": "https://registry.npmjs.org/nock/-/nock-14.0.0-beta.5.tgz", + "integrity": "sha512-u255tf4DYvyErTlPZA9uTfXghiZZy+NflUOFONPVKZ5tP0yaHwKig28zyFOLhu8y5YcCRC+V5vDk4HHileh2iw==", "dev": true, "dependencies": { - "debug": "^4.1.0", "json-stringify-safe": "^5.0.1", "propagate": "^2.0.0" }, diff --git a/package.json b/package.json index ba884be..1d838df 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "@typescript-eslint/eslint-plugin": "^5.56.0", "cross-fetch": "^3.1.5", "jest": "^29.6.2", - "nock": "^14.0.0-beta.4", + "nock": "^14.0.0-beta.5", "publint": "^0.2.7", "ts-jest": "^29.1.0", "typescript": "^5.0.2" From aad6a7ec26d1e0625daad02f7c8ccbbe07f11567 Mon Sep 17 00:00:00 2001 From: Mattt Zmuda Date: Wed, 10 Apr 2024 04:16:31 -0700 Subject: [PATCH 5/5] Pin to Node.js 20.11.1 --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2144cbf..966cb77 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,8 @@ jobs: strategy: matrix: # See supported Node.js release schedule at https://nodejs.org/en/about/previous-releases - node-version: [18.x, 20.x] + # FIXME: Tests are failing on Node.js v20.12.1 (https://github.com/replicate/replicate-javascript/issues/237) + node-version: [18.x, 20.11.1] steps: - uses: actions/checkout@v4