chore(v3): fix state management race condition #3203
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| if err := c.setAppUpgradeStatus(types.StateSucceeded, "Upgrade complete"); err != nil { | ||
| return fmt.Errorf("set status to succeeded: %w", err) | ||
| } |
There was a problem hiding this comment.
Bug: Error Handler Fails Post-Success
If setAppUpgradeStatus fails after successfully transitioning to StateSucceeded, the error-handling defer attempts to transition from StateSucceeded to StateAppUpgradeFailed. This transition is likely invalid in the state machine, causing the error handler itself to fail. The status update should either not return an error that triggers the defer, or the defer should check the current state before attempting transitions.
There was a problem hiding this comment.
never mind. im reverting
emosbaugh
changed the title
What this PR does / why we need it:
This PR refactors the state machine implementation to fix state management issues in the v3 API. The key changes include:
Which issue(s) this PR fixes:
[sc-130867]
Does this PR require a test?
Yes - Added new test files:
api/controllers/kubernetes/install/reporting_handlers_test.goapi/controllers/linux/install/reporting_handlers_test.goapi/controllers/linux/upgrade/reporting_handlers_test.goAlso updated existing tests to align with the new state machine signature and status management patterns.
Does this PR require a release note?
Does this PR require documentation?
NONE