load the kubernetes pause image when installing containerd#4981
Merged
Conversation
Contributor
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4981-b1d597a-containerd-1.6.25-k8s-ctrd-2023-12-12T21:00:18Z |
Contributor
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4981-ec0d451-containerd-1.6.25-k8s-ctrd-2023-12-12T21:25:26Z |
Contributor
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4981-8291a12-containerd-1.6.25-k8s-ctrd-2023-12-12T21:37:32Z |
ricardomaraschini
approved these changes
Dec 13, 2023
laverya
deleted the
laverya/load-kubernetes-pause-image-in-containerd
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As demostrated by https://testgrid.kurl.sh/run/laverya-dec12-containerd-k8supgrade, upgrades of kubernetes to 1.27+ fail in airgap when coming more than a few versions. This is because the pause image has not yet been loaded by 1.23, and will not be loaded by the 1.24 upgrade process - because it is a 1.25 (or later) image.
This PR loads the image when it sets that as the pause image in the containerd configuration.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?