Skip to content

chore(ci): test discover_public_ip does not unset var#5463

Merged
emosbaugh merged 3 commits into
mainfrom
emosbaugh/sc-115680/test-public-address-flag
Nov 10, 2024
Merged

chore(ci): test discover_public_ip does not unset var#5463
emosbaugh merged 3 commits into
mainfrom
emosbaugh/sc-115680/test-public-address-flag

Conversation

@emosbaugh
Copy link
Copy Markdown
Contributor

@emosbaugh emosbaugh commented Nov 8, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an issue when installing in AWS, GCP or Azure where the `public-address` passed into the install script via a flag by the end user may be overridden if an alternate is detected using the corresponding cloud provider metadata service.

Does this PR require documentation?

@emosbaugh emosbaugh requested a review from a team as a code owner November 8, 2024 21:41
@emosbaugh emosbaugh merged commit 51ee0c0 into main Nov 10, 2024
@emosbaugh emosbaugh deleted the emosbaugh/sc-115680/test-public-address-flag branch November 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants