From 4d86a78e0d679d35d4e7a01252c9aab22cf1c474 Mon Sep 17 00:00:00 2001
From: Marc Campbell <marc.e.campbell@gmail.com>
Date: Thu, 18 Nov 2021 21:27:39 +0000
Subject: [PATCH] Upload empty file to work around rook issue

---
 pkg/handlers/garbage_collect_images.go |  2 +-
 pkg/registry/images.go                 | 29 +++++++++++++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/pkg/handlers/garbage_collect_images.go b/pkg/handlers/garbage_collect_images.go
index 7f1c789a31..6d8698ce74 100644
--- a/pkg/handlers/garbage_collect_images.go
+++ b/pkg/handlers/garbage_collect_images.go
@@ -46,7 +46,7 @@ func (h *Handler) GarbageCollectImages(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	isKurl, err := kotsadm.IsKurl()
+	isKurl, err := kotsadm.IsKurl() // this is a redundant check, as written today, EnableImageDeletion is an alias for IsKurl
 	if err != nil {
 		response.Error = "failed to check kURL"
 		logger.Error(errors.Wrap(err, response.Error))
diff --git a/pkg/registry/images.go b/pkg/registry/images.go
index e3aeb9645e..ae31acd77c 100644
--- a/pkg/registry/images.go
+++ b/pkg/registry/images.go
@@ -6,9 +6,13 @@ import (
 	"fmt"
 	"math"
 	"path"
+	"path/filepath"
 	"strings"
 	"time"
 
+	"github.com/aws/aws-sdk-go/aws"
+	awssession "github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/s3"
 	"github.com/containers/image/v5/docker"
 	imagetypes "github.com/containers/image/v5/types"
 	"github.com/pkg/errors"
@@ -22,6 +26,7 @@ import (
 	"github.com/replicatedhq/kots/pkg/kotsutil"
 	"github.com/replicatedhq/kots/pkg/logger"
 	"github.com/replicatedhq/kots/pkg/registry/types"
+	kotss3 "github.com/replicatedhq/kots/pkg/s3"
 	"github.com/replicatedhq/kots/pkg/store"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -205,7 +210,7 @@ func deleteUnusedImages(ctx context.Context, registry types.RegistrySettings, us
 
 	searchResult, err := docker.SearchRegistry(ctx, sysCtx, registry.Hostname, "", math.MaxInt32)
 	if err != nil {
-		return errors.Wrap(err, "failed to seacrh registry")
+		return errors.Wrap(err, "failed to search registry")
 	}
 
 	digestsInRegistry := map[string]string{}
@@ -342,6 +347,11 @@ func runGCCommand(ctx context.Context) error {
 		return errors.Wrap(err, "failed to list registry pods")
 	}
 
+	// let's create an empty file named "empty" in a well-known location to work around a bug in how ceph and the registry
+	// operate together: https://github.com/goharbor/harbor/issues/11929#issuecomment-828892005
+	// we don't care if this file exists, so just ignore errors for now
+	_ = uploadEmptyFileToRegistry(ctx)
+
 	for _, pod := range registryPods.Items {
 		req := clientset.CoreV1().RESTClient().Post().Resource("pods").Name(pod.Name).Namespace(pod.Namespace).SubResource("exec")
 		parameterCodec := runtime.NewParameterCodec(scheme)
@@ -381,3 +391,20 @@ func runGCCommand(ctx context.Context) error {
 
 	return errors.New("no pods found to run garbage collect command")
 }
+
+func uploadEmptyFileToRegistry(ctx context.Context) error {
+	bucketName := "docker-registry"
+	contents := []byte("")
+	path := filepath.Join("docker", "registry", "v2", "repositories", "empty")
+
+	newSession := awssession.New(kotss3.GetConfig())
+	s3Client := s3.New(newSession)
+
+	_, err := s3Client.PutObject(&s3.PutObjectInput{
+		Body:   bytes.NewReader(contents),
+		Bucket: aws.String(bucketName),
+		Key:    aws.String(path),
+	})
+
+	return err
+}