Add support for font family and font size on fat-cursor. #1
Conversation
|
Thank you, but this seems to be still setting wrong size in some cases, e.g. at the first character of a token with larger font size. I wonder if there is a way to fix this without calling domAtPos twice. Maybe if |
|
I have noticed the same issue and I have filed a feature request here: https://discuss.codemirror.net/t/feature-request-domatpos-side-parameter/3793 And yeah you're right, we should probably take that into account! |
|
Ok attached patch should fix the issue - also added |
| let base = getBase(view); | ||
| let domAtPos = view.domAtPos(head); | ||
| let node = domAtPos ? domAtPos.node : view.contentDOM; | ||
| while (domAtPos && domAtPos.node instanceof HTMLElement) { |
There was a problem hiding this comment.
Should this be if, as after one iteration offset is undefined.
Also i think codemirror returns offset for childNodes not children.
There was a problem hiding this comment.
I'm using while because if you have multiple view plugins adding mark styles then it will result in multiple layers of nested spans.
|
Looks good. Merged. |
No description provided.