Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wasm support using wasmtime #39

Merged
merged 2 commits into from Sep 24, 2019

Conversation

@jgautier
Copy link
Contributor

commented Sep 19, 2019

Adding support for web assembly using wasmtime https://github.com/CraneStation/wasmtime

@jgautier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

Just a little background on the hello world program. It was basically copied from here: https://github.com/CraneStation/wasmtime/blob/master/docs/WASI-tutorial.md#web-assembly-text-example.

Copy link
Member

left a comment

nice! wasm support would be awesome 🕸

languages/webassembly.toml Outdated Show resolved Hide resolved
languages/webassembly.toml Outdated Show resolved Hide resolved
@jgautier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

I updated the installation process. Let me know if this is what you were thinking. Thanks!

@turbio
turbio approved these changes Sep 24, 2019
Copy link
Member

left a comment

yup, lgtm
lets_assemble_web

@turbio turbio merged commit f74d96b into replit:master Sep 24, 2019
2 checks passed
2 checks passed
ci/circleci: build_and_test Your tests passed on CircleCI!
Details
ci/circleci: build_and_test_changed Your tests passed on CircleCI!
Details
@syrusakbary

This comment has been minimized.

Copy link

commented Sep 26, 2019

We just fixed the issue in Wasmer that was causing incorrect prints (related to: wasmerio/wasmer#818 ), and will publish a new version soon!

I will create a PR once that's done to update the engine using Wasmer 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.