From 1be316462bbcdd5a44561844225f52526f34a176 Mon Sep 17 00:00:00 2001 From: Dominic Davis-Foster Date: Mon, 5 Apr 2021 09:43:36 +0100 Subject: [PATCH] Remove pre-commit.ci badge --- repo_helper/blocks/__init__.py | 16 ---------------- .../blocks/docs_shields_block_template.rst | 10 ++-------- .../test_rewrite_readme_input_a_rst_.html | 2 +- .../test_rewrite_readme_input_a_rst_.rst | 6 +----- .../test_rewrite_readme_input_b_rst_.html | 2 +- .../test_rewrite_readme_input_b_rst_.rst | 6 +----- .../test_rewrite_readme_input_c_rst_.html | 2 +- .../test_rewrite_readme_input_c_rst_.rst | 6 +----- 8 files changed, 8 insertions(+), 42 deletions(-) diff --git a/repo_helper/blocks/__init__.py b/repo_helper/blocks/__init__.py index 68b85db6..e4cf98ac 100644 --- a/repo_helper/blocks/__init__.py +++ b/repo_helper/blocks/__init__.py @@ -50,8 +50,6 @@ make_docs_last_commit_shield, make_docs_license_shield, make_docs_maintained_shield, - make_docs_pre_commit_ci_shield, - make_docs_pre_commit_shield, make_docs_pypi_downloads_shield, make_docs_pypi_version_shield, make_docs_python_implementations_shield, @@ -75,8 +73,6 @@ make_last_commit_shield, make_license_shield, make_maintained_shield, - make_pre_commit_ci_shield, - make_pre_commit_shield, make_pypi_downloads_shield, make_pypi_version_shield, make_python_implementations_shield, @@ -311,7 +307,6 @@ class ShieldsBlock: :param docker_shields: Whether to show shields for Docker. Default :py:obj:`False`. :param docker_name: The name of the Docker image on DockerHub. :param platforms: List of supported platforms. - :param pre_commit: Whether to show a shield for pre-commit :param on_pypi: :param primary_conda_channel: The Conda channel the package can be downloaded from. @@ -357,8 +352,6 @@ class ShieldsBlock: "docker_build", "docker_automated", "docker_size", - "pre_commit", - "pre_commit_ci", ) def __init__( @@ -396,7 +389,6 @@ def __init__( self.docker_shields: bool = docker_shields self.docker_name: str = str(docker_name) self.platforms: Iterable[str] = set(platforms or ()) - self.pre_commit: bool = pre_commit self.on_pypi: bool = on_pypi self.primary_conda_channel: str = primary_conda_channel or self.username @@ -421,8 +413,6 @@ def set_readme_mode(self) -> None: self.make_last_commit_shield = make_last_commit_shield self.make_license_shield = make_license_shield self.make_maintained_shield = make_maintained_shield - self.make_pre_commit_ci_shield = make_pre_commit_ci_shield - self.make_pre_commit_shield = make_pre_commit_shield self.make_pypi_version_shield = make_pypi_version_shield self.make_python_implementations_shield = make_python_implementations_shield self.make_python_versions_shield = make_python_versions_shield @@ -450,8 +440,6 @@ def set_docs_mode(self) -> None: self.make_last_commit_shield = make_docs_last_commit_shield self.make_license_shield = make_docs_license_shield self.make_maintained_shield = make_docs_maintained_shield - self.make_pre_commit_ci_shield = make_docs_pre_commit_ci_shield - self.make_pre_commit_shield = make_docs_pre_commit_shield self.make_pypi_version_shield = make_docs_pypi_version_shield self.make_python_implementations_shield = make_docs_python_implementations_shield self.make_python_versions_shield = make_docs_python_versions_shield @@ -534,10 +522,6 @@ def make(self) -> StringList: sections["Tests"].append("coveralls") substitutions["coveralls"] = self.make_coveralls_shield(repo_name, username) - if self.pre_commit: - sections["QA"].append("pre_commit_ci") - substitutions["pre_commit_ci"] = self.make_pre_commit_ci_shield(repo_name, username) - if self.on_pypi: sections["PyPI"] = ["pypi-version", "supported-versions", "supported-implementations", "wheel"] substitutions["pypi-version"] = self.make_pypi_version_shield(pypi_name) diff --git a/repo_helper/blocks/docs_shields_block_template.rst b/repo_helper/blocks/docs_shields_block_template.rst index 17ec1a0e..2dee7402 100644 --- a/repo_helper/blocks/docs_shields_block_template.rst +++ b/repo_helper/blocks/docs_shields_block_template.rst @@ -11,8 +11,7 @@ {% if "Windows" in platforms %}|actions_windows{{ unique_name }}| {% endif %}\ {% if "macOS" in platforms %}|actions_macos{{ unique_name }}| {% endif %}\ {% if tests %}|coveralls{{ unique_name }}| {% endif %}\ -|codefactor{{ unique_name }}|\ -{% if pre_commit %} |pre_commit_ci{{ unique_name }}|{% endif %} +|codefactor{{ unique_name }}| {% if on_pypi %}* - PyPI - |pypi-version{{ unique_name }}| |supported-versions{{ unique_name }}| |supported-implementations{{ unique_name }}| |wheel{{ unique_name }}|{% endif %} {% if conda %}* - Anaconda @@ -22,8 +21,7 @@ {% if docker_shields %}* - Docker - |docker_build{{ unique_name }}| |docker_automated{{ unique_name }}| |docker_size{{ unique_name }}| {% endif %}* - Other - - |license{{ unique_name }}| |language{{ unique_name }}| |requires{{ unique_name }}|\ -{% if pre_commit %} |pre_commit{{ unique_name }}|{% endif %} + - |license{{ unique_name }}| |language{{ unique_name }}| |requires{{ unique_name }}| {% if docs %}.. |docs{{ unique_name }}| {{ make_rtfd_shield(repo_name)[3:] }} @@ -68,9 +66,5 @@ .. |docker_automated{{ unique_name }}| {{ make_docker_automated_build_shield(docker_name, username)[3:] }} .. |docker_size{{ unique_name }}| {{ make_docker_size_shield(docker_name, username)[3:] }} -{% endif %}{% if pre_commit %} -.. |pre_commit{{ unique_name }}| {{ make_pre_commit_shield()[3:] }} - -.. |pre_commit_ci{{ unique_name }}| {{ make_pre_commit_ci_shield(repo_name, username)[3:] }} {% endif %} .. end shields diff --git a/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.html b/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.html index 85d20ef6..8e06d2dd 100644 --- a/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.html +++ b/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.html @@ -21,7 +21,7 @@ GitHub last commit GitHub commits since tagged version Maintenance PyPI - Downloads QA -CodeFactor Grade Flake8 Status mypy status pre-commit.ci status +CodeFactor Grade Flake8 Status mypy status Other License GitHub top language Requirements Status diff --git a/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.rst b/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.rst index 861c3d02..ca0f48ef 100644 --- a/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.rst +++ b/tests/test_files/test_readme_/test_rewrite_readme_input_a_rst_.rst @@ -25,7 +25,7 @@ repo_helper * - Activity - |commits-latest| |commits-since| |maintained| |pypi-downloads| * - QA - - |codefactor| |actions_flake8| |actions_mypy| |pre_commit_ci| + - |codefactor| |actions_flake8| |actions_mypy| * - Other - |license| |language| |requires| @@ -107,10 +107,6 @@ repo_helper :target: https://pypi.org/project/hello-world/ :alt: PyPI - Downloads -.. |pre_commit_ci| image:: https://results.pre-commit.ci/badge/github/octocat/hello-world/master.svg - :target: https://results.pre-commit.ci/latest/github/octocat/hello-world/master - :alt: pre-commit.ci status - .. end shields Installation diff --git a/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.html b/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.html index 85d20ef6..8e06d2dd 100644 --- a/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.html +++ b/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.html @@ -21,7 +21,7 @@ GitHub last commit GitHub commits since tagged version Maintenance PyPI - Downloads QA -CodeFactor Grade Flake8 Status mypy status pre-commit.ci status +CodeFactor Grade Flake8 Status mypy status Other License GitHub top language Requirements Status diff --git a/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.rst b/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.rst index 861c3d02..ca0f48ef 100644 --- a/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.rst +++ b/tests/test_files/test_readme_/test_rewrite_readme_input_b_rst_.rst @@ -25,7 +25,7 @@ repo_helper * - Activity - |commits-latest| |commits-since| |maintained| |pypi-downloads| * - QA - - |codefactor| |actions_flake8| |actions_mypy| |pre_commit_ci| + - |codefactor| |actions_flake8| |actions_mypy| * - Other - |license| |language| |requires| @@ -107,10 +107,6 @@ repo_helper :target: https://pypi.org/project/hello-world/ :alt: PyPI - Downloads -.. |pre_commit_ci| image:: https://results.pre-commit.ci/badge/github/octocat/hello-world/master.svg - :target: https://results.pre-commit.ci/latest/github/octocat/hello-world/master - :alt: pre-commit.ci status - .. end shields Installation diff --git a/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.html b/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.html index 85d20ef6..8e06d2dd 100644 --- a/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.html +++ b/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.html @@ -21,7 +21,7 @@ GitHub last commit GitHub commits since tagged version Maintenance PyPI - Downloads QA -CodeFactor Grade Flake8 Status mypy status pre-commit.ci status +CodeFactor Grade Flake8 Status mypy status Other License GitHub top language Requirements Status diff --git a/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.rst b/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.rst index 861c3d02..ca0f48ef 100644 --- a/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.rst +++ b/tests/test_files/test_readme_/test_rewrite_readme_input_c_rst_.rst @@ -25,7 +25,7 @@ repo_helper * - Activity - |commits-latest| |commits-since| |maintained| |pypi-downloads| * - QA - - |codefactor| |actions_flake8| |actions_mypy| |pre_commit_ci| + - |codefactor| |actions_flake8| |actions_mypy| * - Other - |license| |language| |requires| @@ -107,10 +107,6 @@ repo_helper :target: https://pypi.org/project/hello-world/ :alt: PyPI - Downloads -.. |pre_commit_ci| image:: https://results.pre-commit.ci/badge/github/octocat/hello-world/master.svg - :target: https://results.pre-commit.ci/latest/github/octocat/hello-world/master - :alt: pre-commit.ci status - .. end shields Installation