Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlCipherDatabaseSource is final in 1.6.0 #869

Open
Gericop opened this issue May 9, 2019 · 1 comment
Open

SqlCipherDatabaseSource is final in 1.6.0 #869

Gericop opened this issue May 9, 2019 · 1 comment
Assignees
Labels

Comments

@Gericop
Copy link

@Gericop Gericop commented May 9, 2019

1.6.0 made SqlCipherDatabaseSource final for no reason. Also, onConfigure(ConfigurationBuilder builder) is final for no reason. It was used for setting up things like quoting table and column names.

Could these be made non-final again?

@npurushe npurushe added the bug label May 13, 2019
@npurushe npurushe self-assigned this May 13, 2019
@npurushe npurushe closed this in 7e644ad May 22, 2019
@Gericop
Copy link
Author

@Gericop Gericop commented May 22, 2019

@npurushe onConfigure(builder: ConfigurationBuilder) is still not open in 1.6.1, hence it cannot be overridden for configuring the database.

Loading

@npurushe npurushe reopened this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants