Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable @Version use with method attributes #878

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@jakekdodd
Copy link
Contributor

commented Jun 10, 2019

I apologize if this has been proposed before and @Version is only ElementType.FIELD for a reason—I looked through the issues and couldn't find any prior discussion.

It appears that @Version is the only attribute member annotation whose target is FIELD rather than {FIELD, METHOD}. I did a quick read through AttributeMember and couldn't see any reason not to add METHOD as a valid annotation target.

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 10, 2019

CLA assistant check
All committers have signed the CLA.

@npurushe npurushe merged commit d1ced88 into requery:master Jun 13, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details
@npurushe

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Good catch thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.