Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add cookie handling to readme #79

Closed
chovy opened this issue Dec 5, 2015 · 6 comments
Closed

please add cookie handling to readme #79

chovy opened this issue Dec 5, 2015 · 6 comments
Labels

Comments

@chovy
Copy link

@chovy chovy commented Dec 5, 2015

i want to know how to create a cookie jar as well as parse the cookie jar manually.

edit: and also add custom cookie to the request object.

@analog-nico

This comment has been minimized.

Copy link
Member

@analog-nico analog-nico commented Dec 7, 2015

Hi @chovy the second half of Request's examples section explains the use of the jar option quite well.

Did you open this issue to ask this for your own purposes or do you believe that this is very important and should be added to the Request-Promise README as well?

@chovy

This comment has been minimized.

Copy link
Author

@chovy chovy commented Dec 7, 2015

I would at least add a section pointing to the request docs in the request-promise readme.md

@analog-nico

This comment has been minimized.

Copy link
Member

@analog-nico analog-nico commented Jan 12, 2016

Hi @chovy we are currently working on a brand new Request/Request-Promise documentation. I will make sure to include the cookie handling.

@chovy

This comment has been minimized.

Copy link
Author

@chovy chovy commented Jan 13, 2016

thanks.

@analog-nico analog-nico added the docs label Jul 9, 2016
@ProfessorTom

This comment has been minimized.

Copy link

@ProfessorTom ProfessorTom commented Mar 28, 2017

+1

I would really like to see how to use cookies and cookie jars on the request-promise README.md

@analog-nico

This comment has been minimized.

Copy link
Member

@analog-nico analog-nico commented May 8, 2017

Hey everyone, I just added an example to the README. Please make sure to use request-promise@4.2.1 or higher for this to work. Version 4.2.1 includes a bug fix that made using tough-cookie possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.