implement parsing json response when json is truthy

request · Aug 2, 2011 · 68c17f6 · rgrove · Aug 31, 2011 · benatkin
1 parent 3acd82a
commit 68c17f6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/main.js b/main.js
@@ -289,7 +289,10 @@ Request.prototype.request = function () {
           })
           options.on("end", function () { 
             response.body = buffer
-            options.callback(null, response, buffer) 
+            if (options.json && response.headers['content-type'] === 'application/json') {
+              response.body = JSON.parse(response.body)
+            }
+            options.callback(null, response, response.body) 
           })  
         }
       }

diff --git a/tests/test-body.js b/tests/test-body.js
@@ -65,8 +65,7 @@ for (i in tests) {
     request(test, function (err, resp, body) {
       if (err) throw err;
       if (test.expectBody) {
-        if (test.expectBody !== body) console.log(test.expectBody, body);
-        assert.equal(test.expectBody, body)
+        assert.deepEqual(test.expectBody, body)
       }
       counter = counter - 1;
       if (counter === 0) {