Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

https tests fail on 0.8 #277

Closed
maxogden opened this Issue Jul 1, 2012 · 5 comments

Comments

Projects
None yet
4 participants

maxogden commented Jul 1, 2012

$ node test-https.js
boundary >> 1C1C4C2B-9412-4854-A4C5-AC537FAA4005
--1C1C4C2B-9412-4854-A4C5-AC537FAA4005
content-type: text/html

<html><body>Oh hi.</body></html>
--1C1C4C2B-9412-4854-A4C5-AC537FAA4005

Oh hi.
--1C1C4C2B-9412-4854-A4C5-AC537FAA4005-- --frontier
content-type: text/html

<html><body>Oh hi.</body></html>
--frontier

Oh hi.
--frontier--

assert.js:104
  throw new assert.AssertionError({
        ^
AssertionError: "--1C1C4C2B-9412-4854-A4C5-AC537FAA4005\r\ncontent-type: text/html\r\n\r\n<html><body>Oh hi.</body></html>\r\n--1C1C4C2B-9412-48 == "--frontier\r\ncontent-type: text/html\r\n\r\n<html><body>Oh hi.</body></html>\r\n--frontier\r\n\r\nOh hi.\r\n--frontier--"

I was trying to hit the github API over HTTPS and kept get 500s even though curl worked with the same headers/body so I found these failures. Maybe they're related to my github API 500s?

Contributor

benatkin commented Jul 5, 2012

Error reproduced on both of these versions of node:

(mbp) ~/github/mikeal/request $ nodebrew list
v0.6.19
v0.8.1

current: v0.8.1
(mbp) ~/github/mikeal/request $

So it isn't specific to 0.6.

Contributor

benatkin commented Jul 5, 2012

This particular problem is with the test. It uses a UUID for the boundary, as of 2 months ago.

fc13e18

This makes it so the text from the test, last updated by @jhs on 2011-12-02, doesn't match up.

https://github.com/mikeal/request/blob/master/tests/test-https.js

Contributor

benatkin commented Jul 5, 2012

Oops wrong commit.

69d017d

That's where the 'frontier' thing is coming from though.

Owner

mikeal commented Jul 25, 2012

fixed. with that pull req.

@mikeal mikeal closed this Jul 25, 2012

lerouxb commented Aug 17, 2012

You might want to bump the version of the npm package so that https requests work in recent versions of node without package.json voodoo. ;)

(This isn't part of 2.9.203)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment