Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

feature request: support proxy #32

Closed
dvv opened this Issue May 25, 2011 · 5 comments

Comments

Projects
None yet
4 participants

dvv commented May 25, 2011

Hi!

Please consider the subj, in simplest form of honoring process.env.http_proxy

TIA,
--Vladimir

dvv commented May 25, 2011

Seems it's in, sorry for buzz.

@dvv dvv closed this May 25, 2011

Owner

mikeal commented May 25, 2011

i don't think it would be correct to default a client directed at programmers to use a system default proxy. if your application wants to use the system proxy then setting it using the defaults call is easy enough.

dvv commented May 25, 2011

Yep. I've been just tracking why [nodester-cli] wasn't working...

temsa commented Jan 28, 2012

@mikeal I don't agree that much, if I want to honor both http_proxy, https_proxy, and no_proxy, I have to make a new module that proxies every "request" call, or monkey patch it...

I guess just providing the ability to configure both http_proxy, https_proxy and no_proxy would help to avoid making such a trick, and putting an example how to set their value in the readme would be great.

kimptoc commented Oct 14, 2012

I was going to suggest an option to add a "global" proxy default, but saw this entry, which seems to be asking for what I want...

I am using a 3rd party lib that uses "request" under the covers, but does not expose a way of passing options to "request" - so a means of using a global to pass defaults to request would be nice, pretty please :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment