Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

sending qs with pipes #341

Closed
gyllstromk opened this Issue Oct 12, 2012 · 1 comment

Comments

Projects
None yet
2 participants

I want the URL query to be forwarded with pipes from the request, which I don't think happens correctly currently:

var x = request('http://localhost:'+portOne+'/original?thispart=notsent')
req.pipe(x)
x.pipe(resp)

In the above example, the query '?thispart=notsent' is not forwarded.

I have a fork which attempts to address this: https://github.com/gyllstromk/request
I added a test in test-piped-redirect.js .

However, when running the test, we see that s1's "/original" endpoint is actually called twice: (1) with the /original url, and (2) with /original?[...].

Is this a bug?

Owner

mikeal commented Aug 27, 2014

Is this still an issue?

This is so old I'm closing, if it is actually still an issue just let me know and I'll re-open.

@mikeal mikeal closed this Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment