Skip to content

Loading…

Why isn't `url.query` accounted for? #60

Closed
TooTallNate opened this Issue · 4 comments

3 participants

@TooTallNate

In the case that a pre-parsed url object is passed in for the uri option, is there a reason that the query object and/or string are never accounted for?

Essentially, I'm trying to append a query-param to GET requests, before shipping off the HTTP request with request. Something like this does not work: https://gist.github.com/1148093

Looking deeper into the code, it looks like node-core is the one who drops the ball on handling query. So the real question is, should request pre-process a passed in query option when present? I say yes!

@mikeal
request member

two things.

core should handle this better. there is some other work going on in the url parser this release so we should get a ticket in about this.

i want to hold on fixing in request until there is a discussion about how to fix it in core. i'll make request backport whatever fix that core comes up with, but i don't want the fix we put in to request to conflict with what is decided in core.

@mikeal
request member

we should fix this.

@jdub

Might this be related to bug #204?

@mikeal
request member

Is this still an issue?

This is so old I'm closing, if it is actually still an issue just let me know and I'll re-open.

@mikeal mikeal closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.