Outputs headers in Pascal-Case. #830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I understand that according to the RFC headers aren't case-sensitive. But I ran into a server where they were, phantomjs-ghostdriver (version: 1.9.7). And because this library is used in @webdriverjs. Well you see the problem. The issue is fixed in the phantomjs webserver, but apparently still not shipped. Since it doesn't really matter and most clients do output the headers in Pascal-Case. I thought it might be a good idea to address it here.
|
May have been addressed here aswell I don't read mandarin |
|
I can't reproduce the error in the tests on my machine here at work will try at home on my mac. I don't really see how this failing test has anything to do with the changes I made though 😄 |
|
@albertjan please see #804 (comment) |
|
👍 |
|
When will this pull request be merged? Please also refer to this pull request #669. All the HTTP client tools or browsers I know uses Pascal-Cases. It would be nice if we could use the convention that most people use. I have experienced some errors on special servers that doesn't recognize lowercase headers. |
|
no longer merges cleanly :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that according to the RFC headers aren't case-sensitive. But I ran into a server where they were, phantomjs-ghostdriver (version: 1.9.7). And because this library is used in @webdriverjs. Well you see the problem. The issue is fixed in the phantomjs webserver, but apparently still not shipped
or it's due to me running on windows (ariya/phantomjs#11487). Since it doesn't really matter and most clients do output the headers in Pascal-Case. I thought it might be a good idea to address it here.
@camme I ran into the "cannot get a session token" issue. When connection directly to phantomjs from webdriverjs. With this "fix" it works.