Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixes #1023] Set self._ended to true once response has ended #1025

Merged
merged 1 commit into from Aug 27, 2014

Conversation

Projects
None yet
2 participants
@mridgway
Copy link
Contributor

commented Aug 27, 2014

Not sure where else _ended is used, but this will ensure that the response does not emit end multiple times.

@mikeal

This comment has been minimized.

Copy link
Member

commented Aug 27, 2014

I verified looked through all the places we check for _ended and this fix shouldn't affect any of them negatively. Great patch!

mikeal added a commit that referenced this pull request Aug 27, 2014

Merge pull request #1025 from mridgway/gzipFix
[fixes #1023] Set self._ended to true once response has ended

@mikeal mikeal merged commit e3bc488 into request:master Aug 27, 2014

1 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@mridgway

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2014

Thanks!

@mridgway mridgway deleted the mridgway:gzipFix branch Aug 28, 2014

nylen pushed a commit to nylen/request that referenced this pull request Oct 17, 2014

Merge pull request request#1025 from mridgway/gzipFix
[fixes request#1023] Set self._ended to true once response has ended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.