Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multipart form data in request options. #1027

Merged
merged 2 commits into from Sep 21, 2014

Conversation

Projects
None yet
3 participants
@crocket
Copy link
Contributor

commented Aug 28, 2014

I simply recreated the merge request #925.

@seanstrom

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2014

Can you update your branch with latest please

@crocket

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2014

@seanstrom It's done.

@seanstrom

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2014

@FredKSchott gave the go ahead for this to replace #925

Are we good to merge this guys?
@nylen @mikeal

@nylen

This comment has been minimized.

Copy link
Member

commented Sep 20, 2014

Nitpicky I know, but why formdata instead of formData?

@crocket

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2014

@nylen I was tired, so I didn't think about the name much but just recreated the pull request.

In my opinion, formData looks more conspicuous but uglier than formdata.

I could change the name to whatever name you want as long as it doesn't sound too crazy.

@nylen

This comment has been minimized.

Copy link
Member

commented Sep 20, 2014

camelCase is the convention for request and for Node.js in general. I'll merge if you make that change. Others feel free to weigh in though.

@seanstrom

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2014

+1 on @nylen comments

@crocket

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2014

@nylen @seanstrom Name changed.

nylen added a commit that referenced this pull request Sep 21, 2014

Merge pull request #1027 from crocket/master
Add support for multipart form data in request options.

@nylen nylen merged commit 1112965 into request:master Sep 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@nylen

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

Thanks @crocket!

nylen added a commit to nylen/request that referenced this pull request Oct 17, 2014

Merge pull request request#1027 from crocket/master
Add support for multipart form data in request options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.