Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/refactor request setup tunnel #1120

Merged
merged 2 commits into from Oct 6, 2014

Conversation

Projects
None yet
4 participants
@seanstrom
Copy link
Contributor

commented Oct 2, 2014

A refactoring that came out of #1071
In this pull request I refactored the setupTunnel prototype method.
Basic logic extraction came about and some comments on what's happening

review or comment? @FredKSchott @nylen @mikeal

@mikeal

This comment has been minimized.

Copy link
Member

commented Oct 2, 2014

looks good.

@nylen

This comment has been minimized.

Copy link
Member

commented Oct 3, 2014

👍 but let's tackle the simpler #1103 first, at a glance it looks like it will conflict with this one.

@seanstrom

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2014

@nylen now that we got #1103 is this good to merge ?

@FredKSchott

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2014

+1 looks good to me

@nylen

This comment has been minimized.

Copy link
Member

commented Oct 6, 2014

@FredKSchott I can't seem to find the time to give this a proper review, want to merge it?

@FredKSchott

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2014

Yup, I gave it a good look

FredKSchott added a commit that referenced this pull request Oct 6, 2014

Merge pull request #1120 from seanstrom/support/refactor-request-setu…
…pTunnel

Support/refactor request setup tunnel

@FredKSchott FredKSchott merged commit 76ad48c into request:master Oct 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@FredKSchott

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2014

Thanks @seanstrom !

@seanstrom seanstrom deleted the seanstrom:support/refactor-request-setupTunnel branch Oct 6, 2014

nylen pushed a commit to nylen/request that referenced this pull request Oct 17, 2014

Merge pull request request#1120 from seanstrom/support/refactor-reque…
…st-setupTunnel

Support/refactor request setup tunnel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.